On Tue, Jan 19, 2010 at 11:26 PM, Andres Perera <andres87p@gmail.com> wrote:
Fix: 3 Undeclared local vars with common enough names to warrant breakage
Performance issues with _pacman trying to replicate /usr/bin/pacman with find and other slow tools.
Performance issues with expanding an array (with sometimes hundreds of items) over three times.
Expanding said array to remove already completed entries had the side effect of braking filenames with spaces and or \n.
The full description of fixes are already posted at: http://bugs.archlinux.org/task/16630#comment55779 along with time diffs.
Signed-off-by: Andres P <andres87p@gmail.com> --- First off, thanks. These fixes sound much needed.
contrib/bash_completion | 535 ++++++++++++++++++----------------------------- 1 files changed, 202 insertions(+), 333 deletions(-)
diff --git a/contrib/bash_completion b/contrib/bash_completion index 62e5bc9..65051f5 100644 --- a/contrib/bash_completion +++ b/contrib/bash_completion @@ -1,365 +1,234 @@ -# vim: set ft=sh ts=2 sw=2 et: -# file: /etc/bash_completion.d/pacman - -# Bash completion for pacman -# Original: Manolis Tzanidakis <mtzanidakis@freemail.gr> +# pacman/makepkg completion by Andres Perera <andres87p gmail> # -# Distributed under the terms of the GNU General Public License, v2 or later. +# Distributed under the terms of the GNU General Public License v3 or +# later. Is this strictly necessary? You are changing one piece of code in the entire codebase to require v3 or later and as weird as it sounds, I am not going to let that fly. I won't be merging this unless it is v2 or you give some darn good reasons why we should move to v3.
For the rest of the patch, I think I am just going to test it out locally and then I'll get back to you if I don't see anything that blows up as you are right in it being a total revision of the original. -Dan