Re: [pacman-dev] [PATCH 1/4] makepkg: ignore empty global attributes for SRCINFO

5 Nov 2014

On 04/11/14 23:10, Dave Reisner wrote:
...
---
 scripts/makepkg.sh.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index 86f8a77..9048676 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -2385,7 +2385,7 @@ extract_global_var() {
      array_build ref "$attr"
      [[ ${ref[@]} ]] && array_build "$outputvar" "$attr"
  else
-		[[ -v $attr ]] && printf -v "$outputvar" %s "${!attr}"
+		[[ ${!attr} ]] && printf -v "$outputvar" %s "${!attr}"
  fi
 }
Does this need pulled only when the SRCINFO patch goes in, or is it an
independent change and thus needs a better commit title?

    

Allan McRae