On Tue, Apr 5, 2011 at 1:37 PM, Dan McGee <dpmcgee@gmail.com> wrote:
On Sun, Apr 3, 2011 at 6:26 PM, Allan McRae <allan@archlinux.org> wrote:
On 03/04/11 20:49, Sebastian Nowicki wrote:
diff --git a/lib/libalpm/Makefile.am b/lib/libalpm/Makefile.am index fb224a5..21f7057 100644 --- a/lib/libalpm/Makefile.am +++ b/lib/libalpm/Makefile.am @@ -7,7 +7,7 @@ include_HEADERS = alpm_list.h alpm.h
DEFS = -DLOCALEDIR=\"@localedir@\" @DEFS@
-AM_CFLAGS = -pedantic -D_GNU_SOURCE +AM_CFLAGS = -pedantic -Wshadow -D_GNU_SOURCE
I have not gone through all of these changes... I think adding extra warnings etc should be done in configure.ac and only when --enable-debug is specified (as is currently done with stack protector, -Werror etc). Yes, this is the only place they belong, definitely not in the Makefile (and only in the libalpm Makefile, why?).
It was added to the pacman Makefile as well (later down in the patch), wasn't really sure where to put it since I couldn't find other warning flags (aside from -Wall). I guess I'll just put it in the configure.ac script for now. It can always be removed later if it causes issues. Might even check if icc produces different results.