Dan McGee wrote:
On Sat, May 10, 2008 at 11:31 AM, Allan McRae <mcrae_allan@hotmail.com> wrote:
if((fp = alpm_pkg_changelog_open(pkg)) == NULL) { - /* TODO after string freeze use pm_fprintf */ - fprintf(stderr, _("error: no changelog available for '%s'.\n"), + pm_fprintf(stderr, PM_LOG_ERROR, "no changelog available for '%s'.\n",
Ooo, nice.
Any chance you want to fold this into a bigger patch, hopefully slightly tested, finding more of these types of things? This one wasn't alone.
$ grep 'fprintf.*error' * | wc -l 41
Sure, I was just picking out some small things to tidy up but they always turn out to be bigger that you expected!
Of course, this gives me second thoughts- we are using a libalpm defined logging constant in our front end application. should we be doing this?
Hmm.... It is a publicly available define so I guess it is alright. Alternatively, we essentially duplicate the define for use in the frontend. which seems wasteful.