On Nov 14, 2007 6:18 AM, Nagy Gabor <ngaba@bibl.u-szeged.hu> wrote:
Hi! Patch attached. See the patch description for details. Bye, ngaba
Seems OK to me, anyone else see anything weird here? I've applied it locally. <http://code.toofishes.net/gitweb.cgi?p=pacman.git;a=commitdiff;h=64bab41ecc1f795433fd1a3e5e74e7d018565ffa> Nagy- two small favors to ask of you for future patches. And this is really for anyone on the list, but I just noticed it here: 1. git-am likes it a lot better if you format your commit message with the subject, then a *blank line* (not just a newline), and then the commit message. 2. Can you please try to use punctuation where it seems appropritate? I'm fine with having to fix up some English usage stuff, but punctuation makes it easier for us all to read the first time around. This applies to both commit messages and comments in the code (such as the doxygen comment in this patch). -Dan