Re: [pacman-dev] [PATCH 2/2] remove dead assignment, spotted by clang

On 26/04/10 02:48, Serge Ziryukin wrote:

Signed-off-by: Serge Ziryukin<ftrvxmtrx@gmail.com> --- src/pacman/util.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/pacman/util.c b/src/pacman/util.c index 5099237..c37c8b0 100644 --- a/src/pacman/util.c +++ b/src/pacman/util.c @@ -648,7 +648,6 @@ void print_packages(const alpm_list_t *packages) string = strreplace(temp, "%s", size); free(size); free(temp); - temp = string; } printf("%s\n",string); free(string);

I'd prefer to keep this there. That way, if any further fields get added below that one, we will not have to remember to put that line back. That line should be optimized away by any good compiler anyway. Allan