On Fri, Dec 07, 2007 at 12:01:51PM -0600, Aaron Griffin wrote:
On Dec 7, 2007 11:37 AM, Nagy Gabor <ngaba@bibl.u-szeged.hu> wrote:
So my suggestion: implement a .changelog field to pmpkg_t and follow our usual method to query it, and modify _alpm_db_read and maybe _alpm_db_write. Since this is a new file (descfile) we need a new INFRQ_CHANGELOG infolevel.
I actually prefer Allan's method much much more. It is very clean and functions the way an accessor should. If changing an accessor changes like 4 files and 7 different functions, it's garbage.
I'm not sure which one I prefer. Sure, Allan's method is practical and easy, (I believe the code could be even more elegant by reusing the existing _alpm_unpack function), but doesn't it go in the opposite direction of having every code specific to the db behind be_files.c? And I don't know if reading the archive from various places in the code is really elegant.