Re: [pacman-dev] [PATCHv2 2/2] pmtest: add memory check to tests with valgrind

On 04/02/14 03:05, Andrew Gregory wrote:

Signed-off-by: Andrew Gregory --- test/pacman/README | 5 +++++ test/pacman/pmtest.py | 1 + 2 files changed, 6 insertions(+)

diff --git a/test/pacman/README b/test/pacman/README index 2516a8a..8d8354a 100644 --- a/test/pacman/README +++ b/test/pacman/README @@ -62,6 +62,11 @@ This example will run all tests from the "tests" directory. Use the "help" option to get the full list of parameters: ./pactest.py --help

+When run with the `--valgrind' option, an additional rule will be added to all +tests to check for memory leaks. To use `--valgrind' when running the full +test suite, run: + make PY_LOG_FLAGS=--valgrind check + The following pieces of software are required to run the pactest suite:

Awesome! Is this what you are seeing when running the tests with valgrind? # FAIL: 14 FAIL: test/pacman/tests/ignore002 FAIL: test/pacman/tests/ignore003 FAIL: test/pacman/tests/ignore004 FAIL: test/pacman/tests/provision010 FAIL: test/pacman/tests/provision012 FAIL: test/pacman/tests/provision020 FAIL: test/pacman/tests/provision022 FAIL: test/pacman/tests/sync-nodepversion02 FAIL: test/pacman/tests/sync-nodepversion04 FAIL: test/pacman/tests/sync1008 FAIL: test/pacman/tests/sync300 FAIL: test/pacman/tests/upgrade071 FAIL: test/pacman/tests/upgrade075 FAIL: test/pacman/tests/upgrade077 I note this is down from 64 after your export freeing functions patch! Allan