Re: [pacman-dev] [PATCH] makepkg: guard against undefined git pinned sources

On 26/5/20 1:52 pm, Eli Schwartz wrote:

If something like source=(..."#commit=") is used, e.g. due to failed variable expansion, we try to check out an empty refspec as nothing at all, and end up just running "git checkout". This happens because we fail at variable expansion too -- so let's quote our variables properly and make sure git sees this as an empty refspec, so it can error out.

Also make sure it is interpreted as a ref instead of a path.

Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> ---

This ensures that something like https://bugs.archlinux.org/task/66729 cannot happen again.

Patch good. Worth checking if this can happen with other VCS too. A