On 01/06/18 at 12:56am, Jelle van der Waa wrote:
Thanks for the review!
On 01/04/18 at 07:23pm, Andrew Gregory wrote:
On 01/01/18 at 02:53pm, Jelle van der Waa wrote:
...
+ +*format*:: + Denotes the file format, represented by a number.
Can we be more specific here? @Allan: do you intend to keep this as a plain integer or use something more complex for updates?
More specific as in? I guess "file format version" would be more specific?
I meant more specific as in what kind of number (i.e. a plain positive integer as opposed to a float). ...
+*installed (array)*:: + The installed packages at build time including the version of the package.
The actual format of the package name and version should be described here. Looking at the actual code, this is also broken for any packages that include spaces in the name...
Spaces in a name is not legal I assume?
Unfortunately, what makepkg accepts as a valid package name and what libalpm accepts are not the same (improving that is on my TODO list). libalpm accepts any characters except '\n', '/', and NUL. The packages being listed weren't necessarily built by makepkg, so they can include the full range of characters that libalpm allows. I keep a list of the various pacman/alpm/makepkg restrictions here: https://wiki.archlinux.org/index.php/User:Apg#pacman_LIMITS