4 Jan
2016
4 Jan
'16
3:59 a.m.
On 31/12/15 23:19, Rikard Falkeborn wrote:
The signedness of char is implementation defined. Since the alpm_graph state is clearly meant to be signed, make the signedness explicit.
This fixes bugs on systems where char is unsigned, in comparissons of the following type:
if(v.state == -1)
which, if state is unsigned, will never be true due to integer promotion rules.
Fixes failing test/pacman/tests/sync012.py when compiling with -funsigned-char.
Fixes two warnings [-Wtype-limits] for comparissons with -1 when compiling with -funsigned-char.
Pulled.