On 16/03/10 09:13, Xavier Chantry wrote:
On Mon, Mar 15, 2010 at 11:58 PM, Allan McRae<allan@archlinux.org> wrote:
On 16/03/10 08:53, Xavier Chantry wrote:
We cannot do a strict check for asciidoc because released source tarballs have man pages already built, and it should be possible to install them without having asciidoc.
This patch attempts to improve the situation in two ways : 1) disable doc by default 2) print a warning if docs are enabled but asciidoc is not installed
Should that be a warning or an error? I think it would be much better to fail during the configure.
See the first paragraph 'We cannot do a strict check..' It is a very stupid problem..
Maybe a solution would be to have a strict asciidoc checking by default, and add a configure option to skip that check (and maybe building of docs but not install). Then we could also keep docs enabled by default.
Lets just demonstrate I have not looked into this myself... :P How is this handled for a release tarball? I suspect that there must be something in the configure.ac that stops asciidoc usage then. Can we not add the asciidoc check in that if/else check? I could be missing something... Allan