On Sun, Oct 11, 2009 at 7:57 AM, Allan McRae <allan@archlinux.org> wrote:
Dan McGee wrote:
On Sun, Oct 11, 2009 at 6:59 AM, Allan McRae <allan@archlinux.org> wrote:
The current --skip-integ isa bit weird. It does not skip integrity checks, but instead does them and prints a warning. Change this behaviour to actually skipping the checks.
I (we?) did this on purpose; we didn't want to skip the following check:
elif [ ${#integrity_sums[@]} -gt 0 ]; then error "$(gettext "Integrity checks (%s) differ in size from the source array.")" "$integ"
That seems strange to me. If you are skipping integrity checks, then do you really care if the array size is wrong?
I thought this point got brought up here and no one objected (and I agreed with Xavier, maybe offline somewhere): http://bugs.archlinux.org/task/15830 Xavier: "I prefer Profjim's patch, except I would keep the error in case of incomplete (whats the point of letting an incomplete checksums array in a pkgbuild...)" The only change I really think makes sense is only allow --skip-integ if there are no checksum arrays at all; that way you can never produce an invalid source package; I would assume we shouldn't allow source package creation without integrity sums? -Dan