On Wed, Jan 14, 2009 at 6:12 AM, Allan McRae <allan@archlinux.org> wrote:
Bryan Ischo wrote:
Allan McRae wrote:
Bryan Ischo wrote:
Signed-off-by: Bryan Ischo <bryan@ischo.com> --- pactest/README | 14 +++++--------- 1 files changed, 5 insertions(+), 9 deletions(-)
It is much easier for us to comment on these patches if they are sent inline.
My apologies. I am new to git and I don't know how these things are typically done. After some research, I found this command for creating patches and sending them off via email:
git format-patch --signoff --stdout --attach HEAD^^ | git imap-send
This puts the patch emails as draft emails on my IMAP server, and I send them from there. I've just read the documentation for git format-patch and I believe that you are saying that I should add the "--inline" option when generating patch emails in this way ... right? If so, I'll be happy to do that in future.
I use "git format-patch master" then "git send-email <patch>". See http://wiki.archlinux.org/index.php/Super_Quick_Git_Guide#Sending_patches
I believe submitting-patches also mentions to keep patches in the body of the email. I do see that the key word "inline" is not in there. -Dan