On Mon, Aug 27, 2007 at 10:20:13AM -0400, Dan McGee wrote:
On 8/27/07, Xavier <shiningxc@gmail.com> wrote:
That might be the best solution, and then ensure you set the error value as necessary. Of course, if an error can be specified well enough by simply having a NULL return instead of syncpkgs being set, then I guess there isn't too much of a problem there. Basically I'm indecisive.
I don't think we can make the distinction between an empty list of packages (ie no upgrade), and an error, so I'll go with the **list argument :)
Well actually ignore my original comment. Now I see it is trans.c that has always been weird with its alpm_trans_sysupgrade function. Perhaps that should change (probably post-3.1).
A wrapper function might be best for now, and that way we don't have to deal with the NULL trans argument (just leave that out of the wrapper).
Ok, sounds good.