Dan McGee wrote:
- --) OPT_IND=0; shift; break;; + --) OPT_IND=0; continue; break;;
Is it just me, or does this make no sense at all (continue followed by break)? And the problem now is our $@ is not properly shifted for this flag to even do anything.
Yeah, I noticed this funny continue; break thing, but then I guess I got disturbed trying to find out what OPT_IND was and failing.
*) usage; exit 1 ;; # E_INVALID_OPTION esac - shift done
if [ "$HOLDVER" = "1" -a "$FORCE_VER" != "" ]; then --
I guess I'm thinking this is a well-intentioned patch, but should we try to attack the faulty $@ problem instead?
Agreed, that was exactly my sentiment. Before finding a workaround, please try to find more about what the issue actually is. Try to write a simple testcase reproducing the problem.