Aaron Griffin wrote:
On Sat, May 17, 2008 at 10:28 AM, Geoffroy Carrier <geoffroy.carrier@koon.fr> wrote:
- Still, lightweight means smater => Don't use "$_svntrunk" ${something} instead of $_svntrunk $something
Where exactly is this change? This was an example of the rule I wanted to follow... ie. i did not introduced quotes of $_svntrunk which obviously won't include spaces. (or it's REAAALLY dumb).
Just to be a tad more technical. I always try to use the ${} syntax when I can. It IS more to type, but prevents errors much more and is a good habit to follow. It's a minor thing, but I prefer that syntax. I don't think we should really enforce it either way
That's interesting. We don't really enforce anything with the prototypes but it's good to show the preferred syntax with them. I think $pkgname and $pkgver should be safe though, right? They shouldn't contain spaces or other weird things so don't require additional quotings. But pkgdir, srcdir and startdir do. So maybe instead of : cd "$srcdir/$pkgname-$pkgver" we could use : cd ${srcdir}/$pkgname-$pkgver ?