On 15/09/15 08:37, Andrew Gregory wrote:
= Changes since v1 = * file trigger matching has been improved * sync triggers take noextract into account * remove triggers will match if a package update removes a file * remove triggers will not match if the file just moves to another package * documentation started * hooks are run after file conflict and diskspace checks * hooks can be overridden or masked * hooks are validated after parsing * system hook directory is relative to the root * user hook directories can be specified in pacman.conf
= TODO = * improve documentation * tests * compile-time configuration of system directory?
= TODO (deferred) = * status output * run order * allow arguments in Exec * pass triggering package(s)/file(s) to hook
Ack - these are all later things.
= RFC = * Should the system directory be configurable at compile-time? Our other defaults are configurable, but perhaps this shouldn't be because we expect packages to be putting files in it.
I assume the standard sysconfdir/libdir/datarootdir cover this enough. We don't have specific compile time configuration options for anything else pacman related. (apart from --with-makepkg-template-dir which really should just use $datarootdir/makepkg-template - added to my TODO...).
= Caveats = * See alpm-hooks.5.txt in the documentation patch for some remaining caveats regarding file matching.
Aside from the possible configuration of the system hook directory, I consider this feature-complete for our initial implementation. The remaining TODOs marked as deferred are non-essential and can be added later with minimal disruption.
I have pulled patches 1 to 3 as they are all pre-work. I'll take a look at the others now. A