On 12/5/20 3:16 am, Anatol Pomozov wrote:
All users of _alpm_download() have been refactored to the new API. It is time to remove the old _alpm_download() functionality now.
This change also removes obsolete SIGPIPE signal handler functionality (this is a leftover from libfetch days).
Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com> --- lib/libalpm/dload.c | 323 +------------------------------------------- lib/libalpm/dload.h | 4 - 2 files changed, 3 insertions(+), 324 deletions(-)
diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c index 43fe9847..4dbb011f 100644 --- a/lib/libalpm/dload.c +++ b/lib/libalpm/dload.c @@ -78,10 +78,6 @@ enum { };
static int dload_interrupted; -static void inthandler(int UNUSED signum) -{ - dload_interrupted = ABORT_SIGINT; -}
static int dload_progress_cb(void *file, curl_off_t dltotal, curl_off_t dlnow, curl_off_t UNUSED ultotal, curl_off_t UNUSED ulnow) @@ -236,8 +232,7 @@ static size_t dload_parseheader_cb(void *ptr, size_t size, size_t nmemb, void *u return realsize; }
-static void curl_set_handle_opts(struct dload_payload *payload, - CURL *curl, char *error_buffer) +static void curl_set_handle_opts(CURL *curl, struct dload_payload *payload) {
This change seems beyond the scope for this patch. Can you split that and the other related changes below into a separate patch. Otherwise fine. A