On Tue, May 20, 2008 at 9:33 PM, Dan McGee <dpmcgee@gmail.com> wrote:
Ahh, I think this is smart as long as we have identical behavior as before. The one thing I may ask, and do not know if this patch does since I haven't actually tested it, is can we make the symlinks in download_sources() relative for files in the build dir? This would make it easier to move your build directory without breaking everything.
For example, instead of a symlink looking like this (in src/): foobar.desktop -> /home/dmcgee/packages/foobar/foobar.desktop It would be: foobar.desktop -> ../foobar.desktop
I think that issue is a bit orthogonal. Also it seems to defeat the recent idea from grabler of having $pkgdir and $srcdir independent, for putting them somewhere else like in tmpfs or whatever. In any cases, I think it is better to just take the patch as is. We can worry about other stuff later.