On 8/13/18 10:13 PM, Luke Shumaker wrote:
On Mon, 13 Aug 2018 21:20:58 -0400, Eli Schwartz wrote:
diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index bb24c633..1ab2ea3c 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -188,6 +188,9 @@ enter_fakeroot() { # Re-sources the PKGBUILD afterwards to allow for other variables that use $pkgver update_pkgver() { newpkgver=$(run_function_safe pkgver) + if (( $? != 0 )); then + error_function pkgver + fi
Why bring $? in to it, why not:
if ! newpkgver=$(run_function_safe pkgver); then error_function pkgver fi
Because that is a complex command and therefore forces errexit to be ignored, hence it will always be successful. Otherwise I would have simply used || Say thank you to http://austingroupbugs.net/view.php?id=537aa -- Eli Schwartz Bug Wrangler and Trusted User