On 16/07/13 02:56, Dave Reisner wrote:
On Mon, Jul 15, 2013 at 09:35:09AM -0500, Dan McGee wrote:
On Thu, Jul 11, 2013 at 5:08 PM, Jonathan Frazier <eyeswide@gmail.com> wrote:
Signed-off-by: Jonathan Frazier <eyeswide@gmail.com> --- contrib/pacdiff.sh.in | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
I'm hoping I'm reading this wrong or haven't had enough coffee yet since it got Ack-ed by Allan, but doesn't this totally fail when pacsave files roll over from foo.conf.9 to foo.conf.10? This is 100% supported by the match and move behavior in libalpm's code in remove.c.
Nope, you're correct. I was thinking about suggesting that we simply switch to using find -regex here if we want to be truly accurate about it. Otherwise, -name '*.pacsave.[0-9]*' is sufficient to cover it.
I was ignoring that possibility because '*.pacsave.[0-9]*' will match too much and who has that many pacsave files? That would require installing, adjusting the configuration, uninstalling, repeat 10x. Allan