2007/2/6, Roman Kyrylych <roman.kyrylych@gmail.com>:
I don't mind about color. Anyway makepkg and initscripts do use colored messages, so why not pacman? Of course it can be customizable (I would prefer common way of doing this in makepkg, initscripts and pacman) and optional (UseColor in pacman.conf), and of course it shouldn't add complexity to code. This patch is hard to read (because it's not unified diff) but as I see it would be better to do not change MSG(NL, ...) to MSG(NL, color(...)), but instead change MSG itself - this would be much cleaner way, IMO.
Forgot to add: IMO it would be better to chage printf(color(...)) to function too. P.S.: what's the principal difference between printf'ing and MSG'ing? -- Roman Kyrylych (Роман Кирилич)