Re: [pacman-dev] [PATCH] makepkg: use single redirection when writing PKGINFO

27 May 2010

      On 28/05/10 02:34, Andres P wrote:
...
Instead of specifying the output file on every echo, leave it to the
caller of write_pkginfo to specify the target.
Signed-off-by: Andres P
---
This is a resubmit of an old patch
No bug fixes on top master (5dffef787df72cc4)
On Sun, May 23, 2010 at 8:13 AM, Allan McRae  wrote:
...
On 23/05/10 21:20, Andres P wrote:
...
Signed-off-by: Andres P
---
Please use more informative commit messages. Â From the commit message I
should know exactly what your patch is doing.
With a decent commit message this patch gets a +1.
Allan
Besides changing the commit message, I decided that putting the
redirection on the function's ending bracket is an unusual construct.
In works in lots of shells, even dash, but it has the tendency of
throwing people off.
Good.  I prefer this way.

Signoff.  Pushed to my post-3.4 branch

Allan