On 17/05/10 18:35, Marc - A. Dahlhaus wrote:
Am Mittwoch, den 05.05.2010, 20:08 +0200 schrieb Marc - A. Dahlhaus [ Administration | Westermann GmbH ]:
Am Mittwoch, den 05.05.2010, 16:13 +1000 schrieb Allan McRae:
On 26/04/10 19:05, Marc - A. Dahlhaus [ Administration | Westermann GmbH ] wrote:
It handled the GLOB_NOMATCH case silently in the default handler. But a debug print would help alot eg. on typos in include rules. You can find an altered version attached.
The updated version looks fine to me now (although I have not thoroughly tested). We will also need an update to the pacman.conf manpage indicating that globbing can be used for Include.
As i'm not an english native, is the following correct?
Marc
--- a/doc/pacman.conf.5 +++ b/doc/pacman.conf.5 @@ -281,7 +281,7 @@ Instructs pacman to ignore any upgrades .PP \fBInclude =\fR path .RS 4 -Include another config file\&. This file can include repositories or general configuration options\&. +Include another config file\&. This file can include repositories or general configuration options\&. Wildcards in path get expanded\&. .RE .PP \fBXferCommand =\fR /path/to/command %u
Is there anything still missing on this one?
It _looks_ fine to me. However, I have not taken it for a test run yet as the patch did not apply easily with git. How are you creating the patch? Can you use "git format-patch" and send the entire patch (it looks like the main one is missing the header) either using "git send-email" or less preferably as an attachment. Allan