On Tue, Jun 7, 2011 at 4:36 PM, Dan McGee <dan@archlinux.org> wrote:
This is a bitch of a diffstat, unfortunately, and the patches aren't all that fun to look through. I have it pushed to my repo as alpm-cleanups if you'd rather grab it there. The bright side is it should successfully build and test after each patch as long as they are applied in the order sent here (or in my repo).
Comments/suggestion/feedback welcome. Once these are applied, I think our API makes a lot more sense from a consumer standpoint as we have a single object, tracked by the "client", tracking all state in the library rather than the state being held in a global variable in the backend library.
This patch series (and the previous one sent and now applied) makes it *much* easier for the next few patches, which will ensure DBs are signature-checked and verified at the right time, and at a time all clients expect them to be checked so error codes can be checked.
Look at the bright side- the overall line differential is at least negative!
Obviously as I said tests did pass at all stages of this patch sequence, but if it makes people feel any better, it also did a successful update on my live system as follows, so rest assured if you want to take these for a test drive your data should be safe. The only "bug" I noticed was running --version spits out a "error: error releasing alpm library" line which I'm fixing now on my working branch. -Dan Targets (54): gcc-libs-4.6.0-6 icu-4.8-1 boost-libs-1.46.1-3 boost-1.46.1-3 chromium-12.0.742.91-1 gnutls-2.12.6.1-1 libcups-1.4.6-3 cups-1.4.6-3 hunspell-1.3.2-1 enchant-1.6.0-2 libpurple-2.8.0-1 finch-2.8.0-1 lib32-gcc-libs-4.6.0-6 nspluginwrapper-1.4.2-1 flashplugin-10.3.181.22-1 gcc-4.6.0-6 glib2-2.28.8-1 icon-naming-utils-0.8.90-2 gnome-icon-theme-3.0.0-2 gtk3-3.0.11-1 libdvbpsi-0.2.0-1 libreoffice-sdk-3.4.0-2 libwebkit-1.4.1-1 man-db-2.6.0.2-2 mercurial-1.8.4-1 php-5.3.6-4 php-apache-5.3.6-4 php-cgi-5.3.6-4 php-curl-5.3.6-4 php-gd-5.3.6-4 php-mcrypt-5.3.6-4 php-pear-5.3.6-4 pidgin-2.8.0-1 python-egenix-mx-base-3.2.0-1 python-sqlalchemy-0.7.1-1 qt-4.7.3-2 raptor-2.0.3-1 subversion-1.6.17-2 telepathy-glib-0.14.7-1 thunderbird-3.1.10-3 v4l-utils-0.8.4-1 vigra-1.7.1-2 vlc-1.1.10-1 vte-common-0.28.0-2 vte-0.28.0-2 wireshark-cli-1.4.7-2 wireshark-gtk-1.4.7-2 xfce4-dev-tools-4.8.0-2 xfce4-xkb-plugin-0.5.4.1-1 xorg-xlsclients-1.1.2-1 xterm-270-1 xulrunner-2.0.1-2 xvidcore-1.3.2-1 zope-interface-3.6.3-1 Total Download Size: 186.92 MiB Total Installed Size: 992.26 MiB Net Upgrade Size: -16.43 MiB