Re: [pacman-dev] [PATCH 1/3] makepkg: Do not provide $pkgdir to build()

On 18/03/15 03:19, David Macek wrote:

--- scripts/makepkg.sh.in | 3 --- 1 file changed, 3 deletions(-)

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 168f334..9843efe 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -3198,9 +3198,6 @@ else

fi

-# set pkgdir to something "sensible" for (not recommended) use during build() -pkgdir="$pkgdirbase/$pkgbase" - if (( GENINTEG )); then mkdir -p "$srcdir" chmod a-s "$srcdir"

Some packages genuinely need this do to poor build systems. $ for i in */*; do unset build; . $i/PKGBUILD; if declare -f build | grep -q pkgdir; then echo $i; fi; done | wc -l 64 OK - most of those are in [community] so probably bad packaging. But is there a reason to remove this? A