On Sat, Dec 01, 2007 at 12:43:21AM +0100, Nagy Gabor wrote:
Some notes: 2. + alpm_list_t *modified = alpm_list_diff(_alpm_db_get_pkgcache(db), dblist, _alpm_pkg_cmp); I would prefer "intersect(dbcache, joined)", because usually joined is a smaller list than dblist, but we have no such function. 3. alpm_list_diff is quite fast (n+m), but it needs to order lists first O(nlogn)+O(mlogm); however dbcache is initially(?) ordered. Note: We had some alpm_list problems nowadays, after this patch alpm_list_diff function becomes crucial...
Slightly off-topic, but a note related to list_diff and list_intersect function : fileconflicts have apparently its own functions (check_filedifference and check_fileconflicts). I wonder if these could be replaced to use generic list functions instead.