On 19/06/10 08:04, Jeff wrote:
If this is an accepted feature, I can resend the patch with manpage updates.
Signed-off-by: Jeff C<jeff@kcaccess.com>
This is a feature that is acceptable. But I do not like using an option=() value to decide whether to run it. I would prefer a "--check" option to be added. Then people can choose to run the check function or not without requiring to edit the PKGBUILD. If they always want check() to be run, an alias for makepkg can be used. Also,
@@ -735,7 +739,11 @@ run_function() { fi
msg "$(gettext "Starting %s()...")" "$pkgfunc" - cd "$srcdir" + if [[ -d "$srcdir"/"$pkgname"-"$pkgver" ]]; then + cd "$srcdir"/"$pkgname"-"$pkgver" + else + cd "$srcdir" + fi
# ensure all necessary build variables are exported export CFLAGS CXXFLAGS LDFLAGS MAKEFLAGS CHOST
That is unrelated to the patch... Allan