10 Nov
2022
10 Nov
'22
9:23 a.m.
On 10/11/22 18:57, bp wrote:
I think you (Allan) overlooked that those processing functions return boolean true for success, false for error, instead of the (usual?) int == 0 for success and int != 0 for error.
I had not missed it... we started allowing bool usage in the lead up to 6.0 (in the parallel download patches). I guess not using it in the codebase is a hangover of more limited C99 support when pacman was starting to be written. I think we now require C11(? - it appears this check got lost in the transition to meson...), so I see no reason to continue requiring 0/-1 returns for binary return states. Allan