9 Nov
2022
9 Nov
'22
9:20 a.m.
Hi! First of all, thank you a lot Allan for picking this up! I have reviewed the changes on your branch (up to e46c92d31b4ad3428fb3e5a76f0feaa30de31408), first as I would have done for a normal review, then by comparing against the last version I submitted, and it looks very good to me. The way the code is now organized makes sense to me, and is cleaner than my original attempt, as I hoped it would! I am therefore ready to take the blame if/when something breaks! :) Now let's see what a new set of eyes will dig up. Once this has (hopefully) been merged we can have a look at adding more sandboxing (syscall filtering, filesystem restrictions via landlock, for example). Cheers, Remi