Re: [pacman-dev] [PATCH] makepkg: add mtree file into package

On 30.04.2012 08:22, Allan McRae wrote:

Add an mtree file to the package with all file information. This can be added to the local pacman database on install allowing full package verification.

Signed-off-by: Allan McRae ---

Two things I want to query here...

1) bsdtar -czf .MTREE .... When creating the package, we use gzip instead of bsdtar's -z option due to it including time stamps. From memory this was important due to package deltas. So I guess that does not apply here?

2) The timestamps are interesting.... - etc/bash_completion.d/burp time=1335764490.307580112 - etc/bash_completion.d/burp time=1335764490.0 The first is from creating the .MTREE file before compressing the package. The second is creating the mtree file from files on the filesystem after the package is installed. Does anyone know what is going on here?

Tar saves the time as a UNIX timestamp so the precision is seconds. file systems range from 1 second precision to (for whatever reason) 1 nanosecond. Therefore if you extract the tarball the extra precision you had before will simply be cut off.

I guess we can just round the times in the mtree file to the nearest second when checking.

IMHO convert to int, don't round, but since we also have md5 sums, I think checking should better use those. -- Florian Pritz