[pacman-dev] [PATCH 1/1] makepkg: set umask 0022 again after syncing deps
From: Felix Glaser <neindochoh.kraut@mailbox.org> makepkg configures the umask 0022 as a sane default for building packages. After installing dependencies, it sources `/etc/profile` again. If the user configured a umask other than Arch's default of 0022 (or 022) in `/etc/profile`, this sane default is now gone and needs to be set again. --- scripts/makepkg.sh.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 63b6c3e1..3bd018f2 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -279,6 +279,10 @@ handle_deps() { shopt -u extglob source /etc/profile &>/dev/null eval "$shellopts" + + # umask might have been changed in /etc/profile + # ensure that sane default is set again + umask 0022 return $R_DEPS_SATISFIED } -- 2.16.2
On 26/02/18 09:10, neindochoh.kraut+archmail@mailbox.org wrote:
From: Felix Glaser <neindochoh.kraut@mailbox.org>
makepkg configures the umask 0022 as a sane default for building packages. After installing dependencies, it sources `/etc/profile` again. If the user configured a umask other than Arch's default of 0022 (or 022) in `/etc/profile`, this sane default is now gone and needs to be set again. --- scripts/makepkg.sh.in | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 63b6c3e1..3bd018f2 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -279,6 +279,10 @@ handle_deps() { shopt -u extglob source /etc/profile &>/dev/null eval "$shellopts" + + # umask might have been changed in /etc/profile + # ensure that sane default is set again + umask 0022
return $R_DEPS_SATISFIED }
I'm sure we handled this at some stage... Applied, A
participants (2)
-
Allan McRae
-
neindochoh.kraut+archmail@mailbox.org