Xavier wrote:

On Sat, Jun 7, 2008 at 6:05 PM, Allan McRae wrote:

...

The patch fixes the warning messages when syncing a package where the local version is newer that the db version. Also, all messages are suppressed when using --print-uris and messages about upgrading or reinstalling are suppressed when using --downloadonly

Signed-off-by: Allan McRae ---

Did you see this : http://archlinux.org/pipermail/pacman-dev/2008-June/011994.html ? I changed the value of pkg_vercmp to provide more informations. I also removed all these messages because I finally found them useless. But if you disagree, you might be able to use the more detailed result of pkg_vercmp to provide a better output.

Um, no.... I missed that completely. I think your version is the much cleaner way to do this. However, it still prints the warning messages ("forcing upgrade" & "is newer than") in _alpm_pkg_compare_versions when using --print-uris and --downloadonly. Allan

On Mon, Jun 9, 2008 at 6:07 AM, Xavier wrote:

On Mon, Jun 9, 2008 at 12:02 PM, Allan McRae wrote:

...

Sure. Is there any warning message that is actually useful when using those two options? I can't think of anything but you and Dan know the code-base far better than I do.

There might be some useful warning / error messages in case something is wrong, like a corrupted database or other problems like that. But I would think that most of them would happen on normal -S operations too, so it might not be a big problem. I am not sure though.

Why not screen it down to errors only? That way we don't hid those if they occur, but the warnings that these messages omit will be gone. I would rather not have special case handling for these in the backend code. -Dan

On Mon, Jun 9, 2008 at 10:48 AM, Allan McRae wrote:

Um, no.... I missed that completely.

I think your version is the much cleaner way to do this. However, it still prints the warning messages ("forcing upgrade" & "is newer than") in _alpm_pkg_compare_versions when using --print-uris and --downloadonly.

But note that my patch totally removes the "uptodate -- skipping" and "uptodate -- reinstalling" messages. I am still wondering whether we want them or not. They might be informative when there is a small number of targets, but when you want to install / reinstall a group : pacman -S base or to complete a group with the missing packages : pacman -S --needed base then it is totally unreadable and useless. Maybe an indicator which shows which targets are already up-to-date would be more useful. Or even always showing the currently installed version of each targets, which is imo a very useful information. Like that column based output did : http://www.archlinux.org/pipermail/pacman-dev/2008-March/011315.html

On Tue, Jun 10, 2008 at 2:51 PM, Allan McRae wrote:

Should these sort of messages be in the backend at all?

All these messages coming from the backend seem a bit weird conceptually to me, even though it uses a callback defined in the frontend. But well, this is done everywhere in libalpm, and it is often more practical, so I don't know. Anyway, I think these uptodate messages could be dropped for now, and then maybe we could find a better way to display this information in the future.