[pacman-dev] [PATCH] Use colon instead of dot separator for chown
On BSD systems using a dot as a separator is not allowed. On Mac OSX it
is deprecated. A colon should be used instead. BSD systems also use the
"wheel" group instead of "root" to indicate the "super user" group. Both
groups use the id of 0.
Signed-off-by: Sebastian Nowicki
On Tue, May 27, 2008 at 2:22 PM, Sebastian Nowicki
On BSD systems using a dot as a separator is not allowed. On Mac OSX it is deprecated. A colon should be used instead. BSD systems also use the "wheel" group instead of "root" to indicate the "super user" group. Both groups use the id of 0.
Signed-off-by: Sebastian Nowicki
I want to do this because Dan always does!
Acked-by: Aaron Griffin
On Tue, May 27, 2008 at 2:26 PM, Aaron Griffin
On Tue, May 27, 2008 at 2:22 PM, Sebastian Nowicki
wrote: On BSD systems using a dot as a separator is not allowed. On Mac OSX it is deprecated. A colon should be used instead. BSD systems also use the "wheel" group instead of "root" to indicate the "super user" group. Both groups use the id of 0.
Signed-off-by: Sebastian Nowicki
I want to do this because Dan always does!
Acked-by: Aaron Griffin
Lol. We actually do patch review around here?
My only suggestion would be removal of the worthless comment and
replacing it by something better such as "change perms to root & root
user group on all systems" or something, as the current comment is
nothing more than a restatement than the code below it. With that
said:
Acked-by: Dan McGee
On Tue, May 27, 2008 at 9:22 PM, Sebastian Nowicki
On BSD systems using a dot as a separator is not allowed. On Mac OSX it is deprecated. A colon should be used instead. BSD systems also use the "wheel" group instead of "root" to indicate the "super user" group. Both groups use the id of 0.
Signed-off-by: Sebastian Nowicki
--- scripts/makepkg.sh.in | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index cc44c68..1209bd0 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -629,8 +629,8 @@ extract_sources() { done
if [ $EUID -eq 0 ]; then - # chown all source files to root.root - chown -R root.root "$srcdir" + # chown all source files to root:0 + chown -R root:0 "$srcdir" fi }
Oops, I forgot to do some communication. When you started reporting macosx/bsd portability problems, I looked back at an old mail which was taken a bit too seriously and turned into a flamewar instead of something useful : http://www.archlinux.org/pipermail/pacman-dev/2007-October/009659.html So it mentioned du and cp problems, which you already found again. I don't understand the source vs . one because source is bash builtin, but Dan mentioned this already back then. The last point was that chown problem so I patched it two days ago : http://shining.toofishes.net/gitweb/gitweb.cgi?p=pacman.git;a=commitdiff;h=e... Anyway I will merge the two patches and fix the comment like Dan said. PS : For doing this, I need my wifi connection back at home, which wasn't working yesterday evening and this morning. I hope it won't last..
On 28/05/2008, at 3:59 PM, Xavier wrote:
Oops, I forgot to do some communication. When you started reporting macosx/bsd portability problems, I looked back at an old mail which was taken a bit too seriously and turned into a flamewar instead of something useful : http://www.archlinux.org/pipermail/pacman-dev/2007-October/009659.html So it mentioned du and cp problems, which you already found again. I don't understand the source vs . one because source is bash builtin, but Dan mentioned this already back then.
I remember reading that thread, but I completely forgot about it. I didn't really understand it then, and I still don't understand it now - it just seems like a huge flamewar. Briefly looking at the pacman-g2 project, the whole thing (pacman vs pacman-g2) looks like a mess, but I won't get into that. It does look like there is interest in a BSD port. I have heard a lot of requests on IRC for "ArchBSD" and such, and at least a few BSD users would like pacman. As for OSX, I'm making a libalpm frontend, so we'll see if there's interest. Fortunately pacman seems to be working perfectly now, it's just the dev toolset (makepkg, repo-add, etc) that needs porting. I haven't found any problems with source, it seems to be working fine for me, so I don't understand that one either.
The last point was that chown problem so I patched it two days ago : http://shining.toofishes.net/gitweb/gitweb.cgi?p=pacman.git;a=commitdiff;h=e...
I was wondering where your repo was :P. -- Sebastian Nowicki
On Wed, May 28, 2008 at 10:36 AM, Sebastian Nowicki
Fortunately pacman seems to be working perfectly now, it's just the dev toolset (makepkg, repo-add, etc) that needs porting.
Ok cool, hopefully we are not too far :)
The last point was that chown problem so I patched it two days ago : http://shining.toofishes.net/gitweb/gitweb.cgi?p=pacman.git;a=commitdiff;h=e...
I was wondering where your repo was :P.
Unfortunately it is outdated now. I am attaching the two uptodate branches as tar.gz of patches. This will be useful for me if I get a connection again to update the repo, or for others if my connection is not fixed :)
On Wed, May 28, 2008 at 11:30 AM, Xavier
Unfortunately it is outdated now. I am attaching the two uptodate branches as tar.gz of patches. This will be useful for me if I get a connection again to update the repo, or for others if my connection is not fixed :)
Crap I used 000* instead of 00* so the 0010 patch was missed.
participants (4)
-
Aaron Griffin
-
Dan McGee
-
Sebastian Nowicki
-
Xavier