cachemoney is a robust and flexible package cache cleaner with a variety of options. Much credit goes to DJ Mills and Pat Brisbin for the ideas behind this script.
Signed-off-by: Dave Reisner dreisner@archlinux.org --- This sort of functionality has been in a few feature requests, and there exist a number of tools that already provide this, but none flexible enough (or portable enough) to be to my liking. This is all bash3 compat with awk, tested on gawk 3.1.8, gawk 4.0.0, bwk (the one true), mawk, and busybox awk (which fscking _sucks_) to do the heavy lifting (rather than bash4). It ends up being insanely fast, with the drawback being that its dependent on the format of the filename to find and consider packages for deletion. In other words, a valid package tarball that isn't compliant with the extglob *.pkg.tar?(.+([^.])) isn't going to be considered.
I'm a fan of the name, but I'm also happy to hear alternatives.
contrib/Makefile.am | 4 + contrib/cachemoney.in | 294 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 298 insertions(+), 0 deletions(-) create mode 100755 contrib/cachemoney.in
diff --git a/contrib/Makefile.am b/contrib/Makefile.am index 69304a4..301de41 100644 --- a/contrib/Makefile.am +++ b/contrib/Makefile.am @@ -1,5 +1,6 @@ OURSCRIPTS = \ bacman \ + cachemoney \ pacdiff \ paclist \ paclog-pkglist \ @@ -14,6 +15,7 @@ EXTRA_DIST = \ PKGBUILD.vim \ bacman.in \ bash_completion.in \ + cachemoney.in \ paclog-pkglist.in \ pacdiff.in \ paclist.in \ @@ -29,6 +31,7 @@ MOSTLYCLEANFILES = $(OURSCRIPTS) $(OURFILES) *.tmp edit = sed \ -e 's|@sysconfdir[@]|$(sysconfdir)|g' \ -e 's|@localstatedir[@]|$(localstatedir)|g' \ + -e 's|@SIZECMD[@]|$(SIZECMD)|g' \ -e '1s|!/bin/bash|!$(BASH_SHELL)|g'
$(OURSCRIPTS): Makefile @@ -50,6 +53,7 @@ all-am: $(OURSCRIPTS) $(OURFILES)
bacman: $(srcdir)/bacman.in bash_completion: $(srcdir)/bash_completion.in +cachemoney: $(srcdir)/cachemoney.in pacdiff: $(srcdir)/pacdiff.in paclist: $(srcdir)/paclist.in paclog-pkglist: $(srcdir)/paclog-pkglist.in diff --git a/contrib/cachemoney.in b/contrib/cachemoney.in new file mode 100755 index 0000000..794ae45 --- /dev/null +++ b/contrib/cachemoney.in @@ -0,0 +1,294 @@ +#!/bin/bash +# +# cachemoney - clean yo pacman cache, dawg +# +# Copyright (C) 2011 Dave Reisner dreisner@archlinux.org +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License +# as published by the Free Software Foundation; either version 2 +# of the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see http://www.gnu.org/licenses/. + + +shopt -s extglob + +declare -a candidates=() cmdopts=() whitelist=() blacklist=() +declare -i delete=0 diskspace=0 dryrun=0 filecount=0 keep=3 move=0 totalsaved=0 +declare cachedir=@localstatedir@/cache/pacman/pkg delim=$'\n' movedir= scanarch= + +msg() { + local mesg=$1; shift + printf "==> $mesg\n" "$@" +} >&2 + +error() { + local mesg=$1; shift + printf "==> ERROR: $mesg\n" "$@" +} >&2 + +die() { + error "$@" + exit 1 +} + +# reads a list of files on stdin and prints out deletion candidates +pkgfilter() { + # there's whitelist and blacklist parameters passed to this + # script after the block of awk. + + awk -v keep="$1" -v scanarch="$2" ' + function parse_filename(filename, parts, count, i, pkgname, arch) { + + count = split(filename, parts, "-") + + i = 1 + pkgname = parts[i++] + while (i <= count - 3) { + pkgname = pkgname "-" parts[i++] + } + + arch = substr(parts[count], 1, index(parts[count], ".") - 1) + + # filter on whitelist or blacklist + if (wlen && !whitelist[pkgname]) return + if (blen && blacklist[pkgname]) return + + if ("" == packages[pkgname,arch]) { + packages[pkgname,arch] = filename + } else { + packages[pkgname,arch] = packages[pkgname,arch] SUBSEP filename + } + } + + BEGIN { + # create whitelist + wlen = ARGV[1]; delete ARGV[1] + for (i = 2; i < 2 + wlen; i++) { + whitelist[ARGV[i]] = 1 + delete ARGV[i] + } + + # create blacklist + blen = ARGV[i]; delete ARGV[i] + while (i++ < ARGC) { + blacklist[ARGV[i]] = 1 + delete ARGV[i] + } + + # read package filenames + while (getline < "/dev/stdin") { + parse_filename($0) + } + } + + END { + for (pkglist in packages) { + # idx[1,2] = idx[pkgname,arch] + split(pkglist, idx, SUBSEP) + + # enforce architecture match if specified + if (!scanarch || scanarch == idx[2]) { + count = split(packages[idx[1], idx[2]], pkgs, SUBSEP) + if (count > keep) { + for(i = 1; i <= count - keep; i++) { + print pkgs[i] + } + } + } + } + }' "${@:3}" +} + +size_to_human() { + awk -v size="$1" ' + BEGIN { + suffix[1] = "KiB" + suffix[2] = "MiB" + suffix[3] = "GiB" + suffix[4] = "TiB" + count = 1 + + while (size > 1024) { + size /= 1024 + count++ + } + + sizestr = sprintf("%.2f", size) + sub(/.?0+$/, "", sizestr) + printf("%s %s", sizestr, suffix[count]) + }' +} + +runcmd() { + if (( needsroot )); then + msg "Privilege escalation required" + if sudo -v &>/dev/null && sudo -l &>/dev/null; then + sudo "$@" + else + printf '%s ' 'root' + su -c "$(printf '%q ' "$@")" + fi + else + "$@" + fi +} + +summarize() { + local -i filecount=$# + local seenarch= seen= arch= name= + local -r pkg_re='(.+)-[^-]+-[0-9]+-([^.]+).pkg.*' + + if (( delete )); then + printf -v output 'finished: %d packages removed' "$filecount" + elif (( move )); then + printf -v output "finished: %d packages moved to `%s'" "$filecount" "$movedir" + elif (( dryrun )); then + if (( verbose )); then + msg "Candidate packages:" + while read -r pkg; do + if (( verbose >= 3 )); then + [[ $pkg =~ $pkg_re ]] && name=${BASH_REMATCH[1]} arch=${BASH_REMATCH[2]} + if [[ -z $seen || $seenarch != $arch || $seen != $name ]]; then + printf '%s (%s):\n' "$name" "$arch" + fi + printf ' %s\n' "$pkg" + elif (( verbose >= 2 )); then + printf "$PWD/%s$delim" "$pkg" + else + printf "%s$delim" "$pkg" + fi + done < <(printf '%s\n' "$@" | sort -V) + printf '\n' >&2 + fi + + printf -v output 'finished dry run: %d candidates' "$filecount" + fi + + if (( diskspace )); then + output+=" (diskspace saved: $(size_to_human "$totalsaved"))" + fi + + msg "$output" +} +usage() { + cat <<EOF +usage: ${0##*/} <operation> [options] [targets...] + + Operations: + -d perform a dry run, only finding candidate packages. + -m <movedir> move candidate packages to 'movedir'. + -r remove candidate packages. + + Options: + -a <arch> scan for 'arch' (default: all architectures). + -c <cachedir> scan 'cachedir' for packages (default: @localstatedir@/cache/pacman/pkg). + -f apply force to mv(1) and rm(1) operations. + -h display this help message. + -i <pkgs> ignore 'pkgs', which is a comma separated. Alternatively, + specify '-' to read package names from stdin, newline delimited. + -k <num> keep 'num' of each package in 'cachedir' (default: 3). + -s show diskspace saved by the operation. + -u target uninstalled packages. + -v increase verbosity. specify up to 3 times. + -z use null delimiters for candidate names (only with -v and -vv) + +EOF +} + +if (( ! UID )); then + error "Bad dog, no biscuit. You will be prompted for privilege escalation." + exit 42 +fi + +while getopts ':a:c:dfhi:k:m:rsuvz' opt; do + case $opt in + a) scanarch=$OPTARG ;; + c) cachedir=$OPTARG ;; + d) dryrun=1 ;; + f) cmdopts=(-f) ;; + h) usage + exit 0 ;; + i) if [[ $OPTARG = '-' ]]; then + [[ ! -t 0 ]] && IFS=$'\n' read -r -d '' -a ign + else + IFS=',' read -r -a ign <<< "$OPTARG" + fi + blacklist+=("${ign[@]}") + unset i ign ;; + k) keep=$OPTARG + if [[ $keep != $OPTARG ]] || (( keep < 0 )); then + die 'argument to option -k must be a non-negative integer' + fi ;; + m) move=1 movedir=$OPTARG ;; + r) delete=1 ;; + s) diskspace=1 ;; + u) IFS=$'\n' read -r -d '' -a ign < <(pacman -Qq) + blacklist+=("${ign[@]}") + unset ign ;; + v) (( ++verbose )) ;; + z) delim='\0' ;; + :) die "option '--%s' requires an argument" "$OPTARG" ;; + ?) die "invalid option -- '%s'" "$OPTARG" ;; + esac +done +shift $(( OPTIND - 1 )) + +# remaining args are a whitelist +whitelist=("$@") + +# sanity checks +case $(( dryrun+delete+move )) in + 0) die "no operation specified (use -h for help)" ;; + [^1]) die "only one operation may be used at a time" ;; +esac + +[[ -d $cachedir ]] || + die "cachedir `%s' does not exist or is not a directory" "$cachedir" + +[[ $movedir && ! -d $movedir ]] && + die "move-to directory `%s' does not exist or is not a directory" "$movedir" + +if (( move || delete )); then + # make it an absolute path since we're about to chdir + [[ ${movedir:0:1} != '/' ]] && movedir=$PWD/$movedir + [[ ! -w $cachedir || ( $movedir && ! -w $movedir ) ]] && needsroot=1 +fi + +# unlikely that this will fail, but better make sure +cd "$cachedir" || die "failed to chdir to `%s'" "$cachedir" + +# note that these results are returned in an arbitrary order from awk, but +# they'll be resorted (in summarize) iff we have a verbosity level set. +IFS=$'\n' read -r -d '' -a candidates < \ + <(printf '%s\n' *.pkg.tar?(.+([^.])) | sort -V | + pkgfilter "$keep" "$scanarch" \ + "${#whitelist[*]}" "${whitelist[@]}" \ + "${#blacklist[*]}" "${blacklist[@]}") + +if (( ! ${#candidates[*]} )); then + msg 'no candidate packages found for pruning' + exit 1 +fi + +# do this before we destroy anything +if (( diskspace )); then + totalsaved=$(@SIZECMD@ "${candidates[@]}" | awk '{ sum = $1 } END { print sum }') +fi + +# crush. kill. destroy. +(( verbose )) && cmdopts+=(-v) +if (( delete )); then + runcmd rm "${cmdopts[@]}" "${candidates[@]}" +elif (( move )); then + runcmd mv "${cmdopts[@]}" "${candidates[@]}" "$movedir" +fi + +summarize "${candidates[@]}"
On Wed, Jul 27, 2011 at 3:13 PM, Dave Reisner d@falconindy.com wrote:
cachemoney is a robust and flexible package cache cleaner with a variety of options. Much credit goes to DJ Mills and Pat Brisbin for the ideas behind this script.
Signed-off-by: Dave Reisner dreisner@archlinux.org
This sort of functionality has been in a few feature requests, and there exist a number of tools that already provide this, but none flexible enough (or portable enough) to be to my liking. This is all bash3 compat with awk, tested on gawk 3.1.8, gawk 4.0.0, bwk (the one true), mawk, and busybox awk (which fscking _sucks_) to do the heavy lifting (rather than bash4). It ends up being insanely fast, with the drawback being that its dependent on the format of the filename to find and consider packages for deletion. In other words, a valid package tarball that isn't compliant with the extglob *.pkg.tar?(.+([^.])) isn't going to be considered.
I'm a fan of the name, but I'm also happy to hear alternatives.
Without having tested it, that script might be something I will use but I don't like the current name. I just don't understand the 'money' part in it. A name like cachecleaner would be more intuitive.
On Wed, Jul 27, 2011 at 05:39:46PM -0400, Eric Bélanger wrote:
On Wed, Jul 27, 2011 at 3:13 PM, Dave Reisner d@falconindy.com wrote:
cachemoney is a robust and flexible package cache cleaner with a variety of options. Much credit goes to DJ Mills and Pat Brisbin for the ideas behind this script.
Signed-off-by: Dave Reisner dreisner@archlinux.org
This sort of functionality has been in a few feature requests, and there exist a number of tools that already provide this, but none flexible enough (or portable enough) to be to my liking. This is all bash3 compat with awk, tested on gawk 3.1.8, gawk 4.0.0, bwk (the one true), mawk, and busybox awk (which fscking _sucks_) to do the heavy lifting (rather than bash4). It ends up being insanely fast, with the drawback being that its dependent on the format of the filename to find and consider packages for deletion. In other words, a valid package tarball that isn't compliant with the extglob *.pkg.tar?(.+([^.])) isn't going to be considered.
I'm a fan of the name, but I'm also happy to hear alternatives.
Without having tested it, that script might be something I will use but I don't like the current name. I just don't understand the 'money' part in it. A name like cachecleaner would be more intuitive.
It's mostly just a bad joke[1]. I'll throw out the following alternatives:
* slimcache * paccache-clean (more "standard", but too long imo) * cachetrim * pacuum
NB: We've already got the following packages in the AUR, which I'd like to try and avoid stepping on:
* cacheclean * pacleaner * pkgcacheclean * clearcache
(there may be some that i missed)
Any feedback on functionality? Anyone manage to break it?
d
On 29/07/11 00:36, Dave Reisner wrote:
On Wed, Jul 27, 2011 at 05:39:46PM -0400, Eric Bélanger wrote:
On Wed, Jul 27, 2011 at 3:13 PM, Dave Reisnerd@falconindy.com wrote:
cachemoney is a robust and flexible package cache cleaner with a variety of options. Much credit goes to DJ Mills and Pat Brisbin for the ideas behind this script.
Signed-off-by: Dave Reisnerdreisner@archlinux.org
This sort of functionality has been in a few feature requests, and there exist a number of tools that already provide this, but none flexible enough (or portable enough) to be to my liking. This is all bash3 compat with awk, tested on gawk 3.1.8, gawk 4.0.0, bwk (the one true), mawk, and busybox awk (which fscking _sucks_) to do the heavy lifting (rather than bash4). It ends up being insanely fast, with the drawback being that its dependent on the format of the filename to find and consider packages for deletion. In other words, a valid package tarball that isn't compliant with the extglob *.pkg.tar?(.+([^.])) isn't going to be considered.
I'm a fan of the name, but I'm also happy to hear alternatives.
Without having tested it, that script might be something I will use but I don't like the current name. I just don't understand the 'money' part in it. A name like cachecleaner would be more intuitive.
It's mostly just a bad joke[1]. I'll throw out the following alternatives:
I'll add a -1 for the current name too... Bad jokes are usually a bit funny! :P
- slimcache
- paccache-clean (more "standard", but too long imo)
- cachetrim
- pacuum
How about just paccache? A description line about the usage output would be helpful in figuring out what this does too...
NB: We've already got the following packages in the AUR, which I'd like to try and avoid stepping on:
- cacheclean
- pacleaner
- pkgcacheclean
- clearcache
(there may be some that i missed)
Do this script cover all or most of the features of these scripts? I'm sure the maintainers would be "happy" if there is a name conflict if the script we supply covers their functionality.
Any feedback on functionality? Anyone manage to break it?
I can not really test well as I have a somewhat unique cache set-up and my own cache cleaning script (which has the additional feature of always keeping packages that have versions newer than what is in the repos).
Allan
On Sun, Jul 31, 2011 at 01:47:03PM +1000, Allan McRae wrote:
On 29/07/11 00:36, Dave Reisner wrote:
On Wed, Jul 27, 2011 at 05:39:46PM -0400, Eric Bélanger wrote:
On Wed, Jul 27, 2011 at 3:13 PM, Dave Reisnerd@falconindy.com wrote:
cachemoney is a robust and flexible package cache cleaner with a variety of options. Much credit goes to DJ Mills and Pat Brisbin for the ideas behind this script.
Signed-off-by: Dave Reisnerdreisner@archlinux.org
This sort of functionality has been in a few feature requests, and there exist a number of tools that already provide this, but none flexible enough (or portable enough) to be to my liking. This is all bash3 compat with awk, tested on gawk 3.1.8, gawk 4.0.0, bwk (the one true), mawk, and busybox awk (which fscking _sucks_) to do the heavy lifting (rather than bash4). It ends up being insanely fast, with the drawback being that its dependent on the format of the filename to find and consider packages for deletion. In other words, a valid package tarball that isn't compliant with the extglob *.pkg.tar?(.+([^.])) isn't going to be considered.
I'm a fan of the name, but I'm also happy to hear alternatives.
Without having tested it, that script might be something I will use but I don't like the current name. I just don't understand the 'money' part in it. A name like cachecleaner would be more intuitive.
It's mostly just a bad joke[1]. I'll throw out the following alternatives:
I'll add a -1 for the current name too... Bad jokes are usually a bit funny! :P
Nothin' but a bunch of haters!
- slimcache
- paccache-clean (more "standard", but too long imo)
- cachetrim
- pacuum
How about just paccache? A description line about the usage output would be helpful in figuring out what this does too...
paccache actually sits well with me... adding a bit to the usage should do nicely to sell it.
Do this script cover all or most of the features of these scripts? I'm sure the maintainers would be "happy" if there is a name conflict if the script we supply covers their functionality.
Time to re-review!
- cacheclean
Python. Supports N number of copies to keep from hardcoded cache location with a preview function. Requires that it be run as root. I get a backtrace running it with python2 or python3.
- pacleaner
Python. Supports deletion of uninstalled packages, cached packages, or both. Hardcodes the cache location. So really, this seems to just emulate -Sc,-Scc. I get a backtrace running it with python2 or python3.
- pkgcacheclean
C, linked against alpm. Supports N number of copies to keep with a compile time hardcoded cache location. Allows for dry runs. Inflexible output. Offers diskspace saved in bytes. Compiles, but not against git.
- clearcache
bash4. Its nearly at feature parity with mine. Doesn't offer the same level of output control or the ability to move packages. It's written by DJ Mills, so this one actually works. It has the interesting approach of extracting and parsing the .PKGINFO file from each .pkg.tar?(.*) so its possibly more accurate, but very slow. This is the only one worth talking about in comparison with mine.
- pacprune
Late entry. Pat Brisbin's bash script which is meant to be mostly utilitarian, but scores extremely high in that category. Doesn't, however, offer the ability to do things like prune uninstalled packages easily. Size calculations is possible for the crafty, but not inline with another operation.
Any feedback on functionality? Anyone manage to break it?
I can not really test well as I have a somewhat unique cache set-up and my own cache cleaning script (which has the additional feature of always keeping packages that have versions newer than what is in the repos).
Allan
Now _that_ is an interesting feature. Sadly, the code path I've gone down probably isn't flexible enough to handle this as eloquently as I'd like.
d
On 01/08/11 02:15, Dave Reisner wrote:
On Sun, Jul 31, 2011 at 01:47:03PM +1000, Allan McRae wrote:
Do this script cover all or most of the features of these scripts? I'm sure the maintainers would be "happy" if there is a name conflict if the script we supply covers their functionality.
Time to re-review!
<snip>
I agree with passing over those scripts snipped here... I agree that the following two are really what this script is aiming to replace:
- clearcache
bash4. Its nearly at feature parity with mine. Doesn't offer the same level of output control or the ability to move packages. It's written by DJ Mills, so this one actually works. It has the interesting approach of extracting and parsing the .PKGINFO file from each .pkg.tar?(.*) so its possibly more accurate, but very slow. This is the only one worth talking about in comparison with mine.
I guess the reading of .PKGINFO now is mostly redundant these days as the version is more completely specified with the addition of epoch instead of "force" (which really made packages impossible to order...)
- pacprune
Late entry. Pat Brisbin's bash script which is meant to be mostly utilitarian, but scores extremely high in that category. Doesn't, however, offer the ability to do things like prune uninstalled packages easily. Size calculations is possible for the crafty, but not inline with another operation.
From your description of these scripts, I think we should include your script in contrib.
Minor comments: - Add paccache (or whatever it is named...) to contrib/.gitignore
- Adjust "cachemoney - clean yo pacman cache, dawg"....
- whitespace: + function parse_filename(filename, parts, count, i, pkgname, arch) {
- Adjust "Bad dog, no biscuit. You will be prompted for privilege escalation."
- is the ":" in front of the "a" right? +while getopts ':a:c:dfhi:k:m:rsuvz' opt; do
- it should also (re)move and .sig file alongside the package
Allan
On Tue, Aug 02, 2011 at 11:42:05AM +1000, Allan McRae wrote:
On 01/08/11 02:15, Dave Reisner wrote:
On Sun, Jul 31, 2011 at 01:47:03PM +1000, Allan McRae wrote:
Do this script cover all or most of the features of these scripts? I'm sure the maintainers would be "happy" if there is a name conflict if the script we supply covers their functionality.
Time to re-review!
<snip>
I agree with passing over those scripts snipped here... I agree that the following two are really what this script is aiming to replace:
- clearcache
bash4. Its nearly at feature parity with mine. Doesn't offer the same level of output control or the ability to move packages. It's written by DJ Mills, so this one actually works. It has the interesting approach of extracting and parsing the .PKGINFO file from each .pkg.tar?(.*) so its possibly more accurate, but very slow. This is the only one worth talking about in comparison with mine.
I guess the reading of .PKGINFO now is mostly redundant these days as the version is more completely specified with the addition of epoch instead of "force" (which really made packages impossible to order...)
The "bonus" is that you'll catch files not fitting my naming schema. I think that this is somewhat of an odd case and not really required.
- pacprune
Late entry. Pat Brisbin's bash script which is meant to be mostly utilitarian, but scores extremely high in that category. Doesn't, however, offer the ability to do things like prune uninstalled packages easily. Size calculations is possible for the crafty, but not inline with another operation.
From your description of these scripts, I think we should include your script in contrib.
Minor comments:
- Add paccache (or whatever it is named...) to contrib/.gitignore
done
- Adjust "cachemoney - clean yo pacman cache, dawg"....
already done.
- whitespace:
- function parse_filename(filename, parts, count, i, pkgname, arch) {
Intentional awk-ism. You have no direct way of locally scoping a variable except by declaring it as part of the function parameter list (parameters are always optional). By convention, there's a chunk of whitespace between "required" parameters and scoped variables.
- Adjust "Bad dog, no biscuit. You will be prompted for privilege
escalation."
done.
- is the ":" in front of the "a" right?
+while getopts ':a:c:dfhi:k:m:rsuvz' opt; do
Intentional. It causes getopts to squelch its own error reporting so that I can do it myself.
- it should also (re)move and .sig file alongside the package
Yes, good point. Will implement this.
In the meantime, I've also made the diskspace option the default, since its only adding a single fork (and the stat call itself is fairly light even for a thousand packages).
d
On Tue, Aug 2, 2011 at 7:35 AM, Dave Reisner d@falconindy.com wrote:
On Tue, Aug 02, 2011 at 11:42:05AM +1000, Allan McRae wrote:
On 01/08/11 02:15, Dave Reisner wrote:
On Sun, Jul 31, 2011 at 01:47:03PM +1000, Allan McRae wrote:
Do this script cover all or most of the features of these scripts? I'm sure the maintainers would be "happy" if there is a name conflict if the script we supply covers their functionality.
Time to re-review!
<snip>
I agree with passing over those scripts snipped here... I agree that the following two are really what this script is aiming to replace:
- clearcache
bash4. Its nearly at feature parity with mine. Doesn't offer the same level of output control or the ability to move packages. It's written by DJ Mills, so this one actually works. It has the interesting approach of extracting and parsing the .PKGINFO file from each .pkg.tar?(.*) so its possibly more accurate, but very slow. This is the only one worth talking about in comparison with mine.
I guess the reading of .PKGINFO now is mostly redundant these days as the version is more completely specified with the addition of epoch instead of "force" (which really made packages impossible to order...)
The "bonus" is that you'll catch files not fitting my naming schema. I think that this is somewhat of an odd case and not really required.
- pacprune
Late entry. Pat Brisbin's bash script which is meant to be mostly utilitarian, but scores extremely high in that category. Doesn't, however, offer the ability to do things like prune uninstalled packages easily. Size calculations is possible for the crafty, but not inline with another operation.
From your description of these scripts, I think we should include your script in contrib.
Minor comments: - Add paccache (or whatever it is named...) to contrib/.gitignore
done
- Adjust "cachemoney - clean yo pacman cache, dawg"....
already done.
- whitespace:
- function parse_filename(filename, parts, count, i, pkgname, arch) {
Intentional awk-ism. You have no direct way of locally scoping a variable except by declaring it as part of the function parameter list (parameters are always optional). By convention, there's a chunk of whitespace between "required" parameters and scoped variables.
- Adjust "Bad dog, no biscuit. You will be prompted for privilege escalation."
done.
- is the ":" in front of the "a" right? +while getopts ':a:c:dfhi:k:m:rsuvz' opt; do
Intentional. It causes getopts to squelch its own error reporting so that I can do it myself.
- it should also (re)move and .sig file alongside the package
Yes, good point. Will implement this.
In the meantime, I've also made the diskspace option the default, since its only adding a single fork (and the stat call itself is fairly light even for a thousand packages).
Damn- you're going to have to turn this into a patch as I just pushed a version from your repo. This is also the second time you have forgotten to update gitignore, young grasshopper.
-Dan
On Tue, Aug 02, 2011 at 07:42:13AM -0500, Dan McGee wrote:
On Tue, Aug 2, 2011 at 7:35 AM, Dave Reisner d@falconindy.com wrote:
On Tue, Aug 02, 2011 at 11:42:05AM +1000, Allan McRae wrote:
On 01/08/11 02:15, Dave Reisner wrote:
On Sun, Jul 31, 2011 at 01:47:03PM +1000, Allan McRae wrote:
Do this script cover all or most of the features of these scripts? I'm sure the maintainers would be "happy" if there is a name conflict if the script we supply covers their functionality.
Time to re-review!
<snip>
I agree with passing over those scripts snipped here... I agree that the following two are really what this script is aiming to replace:
- clearcache
bash4. Its nearly at feature parity with mine. Doesn't offer the same level of output control or the ability to move packages. It's written by DJ Mills, so this one actually works. It has the interesting approach of extracting and parsing the .PKGINFO file from each .pkg.tar?(.*) so its possibly more accurate, but very slow. This is the only one worth talking about in comparison with mine.
I guess the reading of .PKGINFO now is mostly redundant these days as the version is more completely specified with the addition of epoch instead of "force" (which really made packages impossible to order...)
The "bonus" is that you'll catch files not fitting my naming schema. I think that this is somewhat of an odd case and not really required.
- pacprune
Late entry. Pat Brisbin's bash script which is meant to be mostly utilitarian, but scores extremely high in that category. Doesn't, however, offer the ability to do things like prune uninstalled packages easily. Size calculations is possible for the crafty, but not inline with another operation.
From your description of these scripts, I think we should include your script in contrib.
Minor comments: - Add paccache (or whatever it is named...) to contrib/.gitignore
done
- Adjust "cachemoney - clean yo pacman cache, dawg"....
already done.
- whitespace:
- function parse_filename(filename, parts, count, i, pkgname, arch) {
Intentional awk-ism. You have no direct way of locally scoping a variable except by declaring it as part of the function parameter list (parameters are always optional). By convention, there's a chunk of whitespace between "required" parameters and scoped variables.
- Adjust "Bad dog, no biscuit. You will be prompted for privilege escalation."
done.
- is the ":" in front of the "a" right? +while getopts ':a:c:dfhi:k:m:rsuvz' opt; do
Intentional. It causes getopts to squelch its own error reporting so that I can do it myself.
- it should also (re)move and .sig file alongside the package
Yes, good point. Will implement this.
In the meantime, I've also made the diskspace option the default, since its only adding a single fork (and the stat call itself is fairly light even for a thousand packages).
Damn- you're going to have to turn this into a patch as I just pushed a version from your repo. This is also the second time you have forgotten to update gitignore, young grasshopper.
-Dan
I blame Allan.
d
P.S. patchcount++
pacman-dev@lists.archlinux.org