[pacman-dev] [PATCH] Remove AC_FUNC_MALLOC check.
We weren't supplying the rpl_malloc function needed if this failed, and didn't check for realloc, so just remove. Signed-off-by: Alastair Hughes <hobbitalastair@gmail.com> --- The build will currently fail if cross compiling or if ac_cv_func_malloc_0_nonnull=no is set, because we don't supply a rpl_malloc function anywhere. As we don't use AC_FUNC_REALLOC either, just assume that we will never encounter a buggy system and remove the check. The other option appears to be to provide a malloc definition somewhere, but in that case it appears that we should also check for realloc. I'm unsure which one should be used - opinions? configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index dd4ac04..f2d3b75 100644 --- a/configure.ac +++ b/configure.ac @@ -308,7 +308,6 @@ PATH_MAX_DEFINED AC_FUNC_FORK AC_FUNC_GETMNTENT AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK -AC_FUNC_MALLOC AC_FUNC_MKTIME AC_FUNC_STRCOLL AC_CHECK_FUNCS([dup2 getcwd getmntinfo gettimeofday memmove memset \ -- 2.9.3
On 31/08/16 11:13, Alastair Hughes wrote:
We weren't supplying the rpl_malloc function needed if this failed, and didn't check for realloc, so just remove.
Signed-off-by: Alastair Hughes <hobbitalastair@gmail.com> ---
The build will currently fail if cross compiling or if ac_cv_func_malloc_0_nonnull=no is set, because we don't supply a rpl_malloc function anywhere. As we don't use AC_FUNC_REALLOC either, just assume that we will never encounter a buggy system and remove the check.
The other option appears to be to provide a malloc definition somewhere, but in that case it appears that we should also check for realloc.
I'm unsure which one should be used - opinions?
We are not providing a malloc definition... So this patch is fine. Allan
participants (2)
-
Alastair Hughes
-
Allan McRae