[pacman-dev] [PATCH] makepkg: do not ignore errors from pacman
* check_deps is being run in a subshell, so exit 1 has no meaning.
* Its return value was also being ignored by the enclosing funcion.
* Local assignments *always* take precedence over subshell's $?
Fixes FS#19840
Although this really ignored *all* errors from pacman except 127, not just
illegal directives in pacman.conf.
Signed-off-by: Andres P
On 20/06/10 12:13, Andres P wrote:
* check_deps is being run in a subshell, so exit 1 has no meaning.
If a line of code has no meaning, remove it. Perhaps add a comment why there is not exit after the error. Otherwise the patch is fine. Allan
On Sat, Jun 19, 2010 at 11:33 PM, Allan McRae
If a line of code has no meaning, remove it. Perhaps add a comment why there is not exit after the error.
I can't do that until I can diff against another one of my patches, 'makepkg: undeclared local variables', which was accepted [1]. The patch also touches check_deps(). Andres P [1] http://mailman.archlinux.org/pipermail/pacman-dev/2010-June/011166.html
participants (2)
-
Allan McRae
-
Andres P