[pacman-dev] [PATCH] Clarify alpm-hooks(5)
While studying gtk-update-icon-cache.hook, which had the following contents: Target = usr/share/icons/*/ Target = !usr/share/icons/*/?* it was not obvious from the documentation what and how this matches, which I'm trying to rectify here, after some consultation with Andrew. Signed-off-by: Přemysl Janouch <p.janouch@gmail.com> --- doc/alpm-hooks.5.txt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/doc/alpm-hooks.5.txt b/doc/alpm-hooks.5.txt index 7c523e2..80f9d09 100644 --- a/doc/alpm-hooks.5.txt +++ b/doc/alpm-hooks.5.txt @@ -58,10 +58,11 @@ defined the hook will run if the transaction matches *any* of the triggers. *Target =* <path|package>:: The file path or package name to match against the active transaction. - File paths refer to the files in the package archive; the installation root - should *not* be included in the path. Shell-style glob patterns are - allowed. It is possible to invert matches by prepending a file with an - exclamation mark. May be specified multiple times. Required. + File paths refer to the files and directories in the package archive; + the installation root should *not* be included in the path. Shell-style + glob patterns are allowed. It is possible to exclude matches by prepending + the path with an exclamation mark. May be specified multiple times, in + which case they are checked in reverse order until one matches. Required. ACTIONS ------- -- 2.9.0
On 24/07/16 06:15, Přemysl Janouch wrote:
While studying gtk-update-icon-cache.hook, which had the following contents:
Target = usr/share/icons/*/ Target = !usr/share/icons/*/?*
it was not obvious from the documentation what and how this matches, which I'm trying to rectify here, after some consultation with Andrew.
Signed-off-by: Přemysl Janouch <p.janouch@gmail.com> --- doc/alpm-hooks.5.txt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/doc/alpm-hooks.5.txt b/doc/alpm-hooks.5.txt index 7c523e2..80f9d09 100644 --- a/doc/alpm-hooks.5.txt +++ b/doc/alpm-hooks.5.txt @@ -58,10 +58,11 @@ defined the hook will run if the transaction matches *any* of the triggers.
*Target =* <path|package>:: The file path or package name to match against the active transaction. - File paths refer to the files in the package archive; the installation root - should *not* be included in the path. Shell-style glob patterns are - allowed. It is possible to invert matches by prepending a file with an - exclamation mark. May be specified multiple times. Required. + File paths refer to the files and directories in the package archive; + the installation root should *not* be included in the path. Shell-style + glob patterns are allowed. It is possible to exclude matches by prepending + the path with an exclamation mark. May be specified multiple times, in + which case they are checked in reverse order until one matches. Required.
I don't like the "in which case they are checked in reverse order until one matches" addition. I don't see this as being anything beyond an implementation detail. Allan
participants (2)
-
Allan McRae
-
Přemysl Janouch