[pacman-dev] [PATCH] Don't bother if a package has already been built when using the --nobuild option
makepkg should not abort with error when a user uses the --nobuild option to extract sources if a package has already been built. Signed-off-by: Anton Fiuman <llexiw@gmail.com> --- scripts/makepkg.sh.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 6e2f1ad..08313bf 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1354,7 +1354,7 @@ devel_check devel_update if [ -f "$PKGDEST/${pkgname}-${pkgver}-${pkgrel}-${CARCH}${PKGEXT}" \ - -a "$FORCE" = "0" -a "$GENINTEG" = "0" -a "$SOURCEONLY" = "0" ]; then + -a "$FORCE" = "0" -a "$GENINTEG" = "0" -a "$SOURCEONLY" = "0" -a "$NOBUILD" = "0" ]; then if [ "$INSTALL" = "1" ]; then warning "$(gettext "A package has already been built, installing existing package...")" install_package -- 1.5.5.3
On Sun, Jun 1, 2008 at 11:41 PM, Anton Fiuman <llexiw@gmail.com> wrote:
makepkg should not abort with error when a user uses the --nobuild option to extract sources if a package has already been built.
Signed-off-by: Anton Fiuman <llexiw@gmail.com>
Seems logical to me, any other comments? Otherwise I'll throw this on maint. -Dan
Dan McGee wrote:
On Sun, Jun 1, 2008 at 11:41 PM, Anton Fiuman <llexiw@gmail.com> wrote:
makepkg should not abort with error when a user uses the --nobuild option to extract sources if a package has already been built.
Signed-off-by: Anton Fiuman <llexiw@gmail.com>
Seems logical to me, any other comments? Otherwise I'll throw this on maint.
Go for it. That should not be an error condition. Some of these if statements are getting very long... I'm looking into how much this can be reduced with the reordering of segments of code. Allan
participants (3)
-
Allan McRae
-
Anton Fiuman
-
Dan McGee