2008/7/20 Allan McRae <allan@archlinux.org>:

Hi,

This is the patch from Thomas with the documentation added. I'm not sure whether when STRIP_DIRS is not defined in makepkg.conf that we should use the default path or just output a warning message saying that it is not defined and no stripping is being done.

If both will be done - that will lessen the amount of unstripped packages made by people because of unmodified makepkg.conf. On the other hand - people should keep their makepkg.conf up to date. -- Roman Kyrylych (Роман Кирилич)

On Mon, Jul 28, 2008 at 10:45 PM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:

aaron@gerolde:~$ [ -z foo bar baz ] -bash: [: too many arguments aaron@gerolde:~$ [ -z "foo bar baz" ] aaron@gerolde:~$

Well don't ask me to explain, but here is a closer test case I think : [xavier@nx7400 ~]$ array=({foo,bar,baz}) [xavier@nx7400 ~]$ [ -z "${array[@]}" ] bash: [: too many arguments

On Mon, Jul 28, 2008 at 11:05 PM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:

On Mon, Jul 28, 2008 at 3:51 PM, Xavier <shiningxc@gmail.com> wrote:

...

On Mon, Jul 28, 2008 at 10:45 PM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:

...

aaron@gerolde:~$ [ -z foo bar baz ] -bash: [: too many arguments aaron@gerolde:~$ [ -z "foo bar baz" ] aaron@gerolde:~$

Well don't ask me to explain, but here is a closer test case I think :

[xavier@nx7400 ~]$ array=({foo,bar,baz}) [xavier@nx7400 ~]$ [ -z "${array[@]}" ] bash: [: too many arguments

Weird. I'd guess this is something to do with globbing taking priority. Seeing as this is just testing for some value, using single quotes fixes the issue.

_______________________________________________ pacman-dev mailing list pacman-dev@archlinux.org http://archlinux.org/mailman/listinfo/pacman-dev

With single quotes, I am not sure it still works correctly. [xavier@nx7400 ~]$ unset array [xavier@nx7400 ~]$ [ -z '${array[@]}' ] || echo array not empty array not empty [xavier@nx7400 ~]$ echo '${array[@]}' ${array[@]} What about handling it just like a normal variable ? [xavier@nx7400 ~]$ array=({foo,bar,baz}) [xavier@nx7400 ~]$ [ -z "$array" ] || echo array not empty array not empty [xavier@nx7400 ~]$ unset array [xavier@nx7400 ~]$ [ -z "$array" ] || echo array not empty [xavier@nx7400 ~]$

On Mon, Jul 28, 2008 at 11:22 PM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:

That'd work, except for cases of idiocy, like... array=('' {foo,bar,baz}

Arf. And guess what, that is like the 1000000000th thing that works like I want with zsh and not with bash... zsh : echo $array -> foo bar baz bash : echo $array -> nothing, because it displays the first element which is an empty string. Anyway, I have something else, look : [xavier@nx7400 ~]$ array=('' {foo,bar,baz}) [xavier@nx7400 ~]$ [ -z "${array[@]}" ] || echo array not empty bash: [: too many arguments array not empty [xavier@nx7400 ~]$ [ -z "${array[*]}" ] || echo array not empty array not empty I never understood what the differences between @ and * were though... Another thing, I just realized that the current code already seems to work like we want, so this is a small issue. We only get that "too many arguments" message which look very odd and let us think that something probably broke.

On Tue, Jul 29, 2008 at 2:06 AM, Henning Garus <henning.garus@googlemail.com> wrote:

On Mon, 28 Jul 2008 23:44:13 +0200 Xavier <shiningxc@gmail.com> wrote:

...

Anyway, I have something else, look : [xavier@nx7400 ~]$ array=('' {foo,bar,baz}) [xavier@nx7400 ~]$ [ -z "${array[@]}" ] || echo array not empty bash: [: too many arguments array not empty [xavier@nx7400 ~]$ [ -z "${array[*]}" ] || echo array not empty array not empty

I never understood what the differences between @ and * were though...

The way I understand it "${array[@]}" is expanded to "foo" "bar" "baz", while "${array[*]}" is expanded to "foo%bar%baz" where % is the first character of $IFS (meaning ' ' if not set otherwise).

So with @ you get several words for the test, which would explain the observed behaviour.

Interestingly enough [[ -z "${array[@]}" ]] seems to work as well...

Hmm now we have too many solutions and I don't know which one to choose. 1) [ -z "$array" ] 2) [ -z "${array[*]}" ] 3) [[ -z "${array[@]}" ]] (the current problematic one is [ -z "${array[@]}" ] ). So you can vote now :)

On Tue, Jul 29, 2008 at 1:45 PM, Dan McGee <dpmcgee@gmail.com> wrote:

I think (2) is what we are looking for. "If the array (as a whole) contains anything, then..."

(2) and (3) should say the same thing, but it is the opposite : "If the array (as a whole) does not contain anything, then..." (1) says (if I understood correctly) : if the first element of the array is empty, then..." But in the general/normal case where there are no empty strings, it should be equivalent to the rest. However, it is not really what I was looking for in the beginning, I would prefer a behavior like this : when the strip option is enabled : * if STRIP_DIRS is not defined, switch back to default value (here we get the backward compatibility) * if STRIP_DIRS is empty, don't strip anything But the second situation is stupid anyway. So we can just handle undefined and empty the same way, and fallback to default value in both cases, which seems easier to do. Short answer : I made a commit on my working branch for the first option yesterday : 1) [ -z "$array" ] I will change it this evening for picking the second option : 2) [ -z "${array[*]}" ]