[pacman-dev] pacman 3.3 API changes
we had a section in the README about API CHANGES BETWEEN 3.1 AND 3.2 do we need the same for 3.2 -> 3.3? As you can see in the attached diff, there were quite a few changes as well :P
we had a section in the README about API CHANGES BETWEEN 3.1 AND 3.2 do we need the same for 3.2 -> 3.3? As you can see in the attached diff, there were quite a few changes as well :P
I will send a patch for this when we are in "patch freeze". (I have 4 pending patches, all of them change API.)
On Sat, Jul 11, 2009 at 2:32 PM, Nagy Gabor
we had a section in the README about API CHANGES BETWEEN 3.1 AND 3.2 do we need the same for 3.2 -> 3.3? As you can see in the attached diff, there were quite a few changes as well :P
I will send a patch for this when we are in "patch freeze". (I have 4 pending patches, all of them change API.)
Great to hear this :) I think your 2 patches on working should be fine for 3.3. What about the two for universal, you consider them ready for inclusion? I believe Dan wanted to include them after 3.3, but I don't know if this was a final decision.
On Sat, Jul 11, 2009 at 2:32 PM, Nagy Gabor
wrote: we had a section in the README about API CHANGES BETWEEN 3.1 AND 3.2 do we need the same for 3.2 -> 3.3? As you can see in the attached diff, there were quite a few changes as well :P
I will send a patch for this when we are in "patch freeze". (I have 4 pending patches, all of them change API.)
Great to hear this :) I think your 2 patches on working should be fine for 3.3. What about the two for universal, you consider them ready for inclusion?
I believe Dan wanted to include them after 3.3, but I don't know if this was a final decision.
The universal branch is not ready, but I consider the 2 patches ready for inclusion (in fact, I have focused on fixing of FS#3492 and FS#5798 with the least API changes). However, I had not much time to test it and the inclusion of a _complete_ universal branch to ~4.0 would be nicer, so I am fine with Dan's roadmap. (However, I have no clue what to do with universal transaction at pacman front-end side...) I will send my "API changes" patch soon, based on my working branch, feel free to modify it, if needed. Bye
From e9d1686e5e54bff2aad12820e335c10603b307db Mon Sep 17 00:00:00 2001 From: Nagy Gabor
Date: Wed, 15 Jul 2009 17:08:28 +0200 Subject: [PATCH] API changes between 3.2 and 3.3
Signed-off-by: Nagy Gabor
Special thanks to my mail client for formatting this. See my git repo for the applicable patch.
On Wed, Jul 15, 2009 at 5:26 PM, Nagy Gabor
From e9d1686e5e54bff2aad12820e335c10603b307db Mon Sep 17 00:00:00 2001 From: Nagy Gabor
Date: Wed, 15 Jul 2009 17:08:28 +0200 Subject: [PATCH] API changes between 3.2 and 3.3 Signed-off-by: Nagy Gabor
--- README | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/README b/README index 1dadc92..131d9dd 100644 --- a/README +++ b/README @@ -246,3 +246,53 @@ API CHANGES BETWEEN 3.1 AND 3.2 - flags: PM_TRANS_FLAG_ALLEXPLICIT, PM_TRANS_FLAG_UNNEEDED and PM_TRANS_FLAG_RECURSEALL + + +API CHANGES BETWEEN 3.2 AND 3.3 +=============================== + +[REMOVED] +- pmsyncpkg_t struct (pmpkg_t is used for all types of transaction targets): + - alpm_sync_get_pkg() + - alpm_sync_get_removes() (use alpm_pkg_get_removes() instead) +- HoldPkg handling (it is the front-end's task): + - alpm_option_get_holdpkgs() + - alpm_option_add_holdpkg() + - alpm_option_set_holdpkgs() + - alpm_option_remove_holdpkg()
you also need to remove the reference to holdpkgs in the same README file, as you mentioned earlier. I did not find any other updates needed.
On Wed, Jul 22, 2009 at 4:01 AM, Xavier
On Wed, Jul 15, 2009 at 5:26 PM, Nagy Gabor
wrote: From e9d1686e5e54bff2aad12820e335c10603b307db Mon Sep 17 00:00:00 2001 From: Nagy Gabor
Date: Wed, 15 Jul 2009 17:08:28 +0200 Subject: [PATCH] API changes between 3.2 and 3.3 Signed-off-by: Nagy Gabor
--- README | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/README b/README index 1dadc92..131d9dd 100644 --- a/README +++ b/README @@ -246,3 +246,53 @@ API CHANGES BETWEEN 3.1 AND 3.2 - flags: PM_TRANS_FLAG_ALLEXPLICIT, PM_TRANS_FLAG_UNNEEDED and PM_TRANS_FLAG_RECURSEALL + + +API CHANGES BETWEEN 3.2 AND 3.3 +=============================== + +[REMOVED] +- pmsyncpkg_t struct (pmpkg_t is used for all types of transaction targets): + - alpm_sync_get_pkg() + - alpm_sync_get_removes() (use alpm_pkg_get_removes() instead) +- HoldPkg handling (it is the front-end's task): + - alpm_option_get_holdpkgs() + - alpm_option_add_holdpkg() + - alpm_option_set_holdpkgs() + - alpm_option_remove_holdpkg()
you also need to remove the reference to holdpkgs in the same README file, as you mentioned earlier. I did not find any other updates needed.
Sounds about right. I fully intend to pull this patch, I just haven't yet. -Dan
participants (3)
-
Dan McGee
-
Nagy Gabor
-
Xavier