[pacman-dev] [Fwd: [arch-general] PKGBUILD and DOS line endings]
Should we be handling this issue? Allan -------- Original Message -------- Subject: [arch-general] PKGBUILD and DOS line endings Date: Sat, 6 Dec 2008 15:32:26 +0100 From: Alessandro Doro <ordo.ad@gmail.com> Reply-To: General Discusson about Arch Linux <arch-general@archlinux.org> To: arch-general@archlinux.org I found in AUR a PKGBUILD with DOS line endings. See what happens: $ makepkg : command not found ==> ERROR: An unknown error has occured. Exiting... makepkg simply sources "$BUILDSCRIPT" and bash treats '\r' literally. The PKGBUILD maintainer is surely to be blamed and I don't think that `makepkg' should try to catch this error (sorry for some innocent user). Just wanted to expose this "feature". bye
On Sat, Dec 6, 2008 at 8:37 AM, Allan McRae <allan@archlinux.org> wrote:
Should we be handling this issue?
I feel like a slightly more descriptive failure message wouldn't hurt. Is it easy to handle? Someone would need to do some playing. -Dan
-------- Original Message -------- Subject: [arch-general] PKGBUILD and DOS line endings Date: Sat, 6 Dec 2008 15:32:26 +0100 From: Alessandro Doro <ordo.ad@gmail.com> Reply-To: General Discusson about Arch Linux <arch-general@archlinux.org> To: arch-general@archlinux.org
I found in AUR a PKGBUILD with DOS line endings. See what happens:
$ makepkg : command not found
==> ERROR: An unknown error has occured. Exiting...
makepkg simply sources "$BUILDSCRIPT" and bash treats '\r' literally.
The PKGBUILD maintainer is surely to be blamed and I don't think that `makepkg' should try to catch this error (sorry for some innocent user).
Just wanted to expose this "feature".
bye
_______________________________________________ pacman-dev mailing list pacman-dev@archlinux.org http://archlinux.org/mailman/listinfo/pacman-dev
On Sat, Dec 6, 2008 at 11:48 AM, Dan McGee <dpmcgee@gmail.com> wrote:
On Sat, Dec 6, 2008 at 8:37 AM, Allan McRae <allan@archlinux.org> wrote:
Should we be handling this issue?
I feel like a slightly more descriptive failure message wouldn't hurt. Is it easy to handle? Someone would need to do some playing.
I don't think this is easy to handle, as it's at the bash level. You could maybe run "file" on the PKGBUILD to check... $ file testdos testdos: ASCII text, with CRLF line terminators $ file testunix testunix: ASCII text
participants (3)
-
Aaron Griffin
-
Allan McRae
-
Dan McGee