[pacman-dev] [PATCH] makepkg: fix issue with filenames with spaces break and noextract
Specifying a filename with spaces in a PKGBUILDs noextract array fails due to a lack of quoting. Fixes FS#25100. Reported-by: Thomas Weißschuh <<thomas_weissschuh@lavabit.com> Signed-off-by: Allan McRae <allan@archlinux.org> --- Can probably go on maint in case we ever make another release from there. scripts/makepkg.sh.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 16c4400..74dfa43 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -758,7 +758,7 @@ extract_sources() { local netfile for netfile in "${source[@]}"; do local file=$(get_filename "$netfile") - if in_array "$file" ${noextract[@]}; then + if in_array "$file" "${noextract[@]}"; then #skip source files in the noextract=() array # these are marked explicitly to NOT be extracted continue -- 1.7.6
Of course the version on my working branch has a subject that makes some actual sense...
participants (1)
-
Allan McRae