[pacman-dev] [patch] Spell check for PKGBUILDs :p (aka check-buildscript)
I was looking at the commented out code in makepkg to unset all vars in PKGBUILD before including and I think I've cracked it. So I went to test it on arch's main, extra and unstable repo, and there's several PKGBUILDs with miss spelled vars. As a result I've created check-buildscript, this just runs some sanity/spell checks on a PKGBUILD script. People should run it before submitting a PKGBUILD. Andrew
From 1d77fdf087d37ed839c892484df26c471ed79f9a Mon Sep 17 00:00:00 2001 From: Andrew Fyfe
Date: Thu, 29 Mar 2007 16:24:59 +0100 Subject: [PATCH 1/1] Added check-buildscript
check-buildscript does some basic sanity checks on a build script.
People should run check-buildscript before they submit a build script.
Signed-off-by: Andrew Fyfe
Small bug fix. Andrew Fyfe wrote:
I was looking at the commented out code in makepkg to unset all vars in PKGBUILD before including and I think I've cracked it. So I went to test it on arch's main, extra and unstable repo, and there's several PKGBUILDs with miss spelled vars.
As a result I've created check-buildscript, this just runs some sanity/spell checks on a PKGBUILD script. People should run it before submitting a PKGBUILD.
Andrew
------------------------------------------------------------------------
_______________________________________________ pacman-dev mailing list pacman-dev@archlinux.org http://www.archlinux.org/mailman/listinfo/pacman-dev
From 2ff98926b6c8648f7aadede27e981dad6644e524 Mon Sep 17 00:00:00 2001 From: Andrew Fyfe
Date: Thu, 29 Mar 2007 16:38:07 +0100 Subject: [PATCH 2/2] Fixed infinite loop in options check.
Signed-off-by: Andrew Fyfe
On 3/29/07, Andrew Fyfe
I was looking at the commented out code in makepkg to unset all vars in PKGBUILD before including and I think I've cracked it. So I went to test it on arch's main, extra and unstable repo, and there's several PKGBUILDs with miss spelled vars.
As a result I've created check-buildscript, this just runs some sanity/spell checks on a PKGBUILD script. People should run it before submitting a PKGBUILD.
Andrew
Wow, you went patch crazy! I have a lot of other things to do today so I probably won't be pushing some of this through quite yet, but hopefully it will get looked at soon. I'd also like to get Giovanni's gettext patch through first- we are going to have some conflicting merges with two big changes to makepkg, and I feel like it is easier to push his first. More on topic- This patch may duplicate some of the functionality of the namcap utility that has been written before- you may want to read up on it. It is in the Arch extra repository, or you can get the source directly- http://projects.xennet.org/namcap. I don't know how big you are on python, but that is what namcap is written in. If there is any functionality in this script that isn't covered by namcap, that would be the place to put it. It needs an update anyway, it hasn't changed in a while. -Dan
Wow, you went patch crazy! I have a lot of other things to do today so I probably won't be pushing some of this through quite yet, but hopefully it will get looked at soon. I'd also like to get Giovanni's gettext patch through first- we are going to have some conflicting merges with two big changes to makepkg, and I feel like it is easier to push his first. :D It's raining and I'm off college this week, not much to do lol.
When you get the gettext stuff in, I'll update the fakeroot patches. Until then I'll hold of on the rest of my patches, don't want to get labeled a patch whore :p
More on topic- This patch may duplicate some of the functionality of the namcap utility that has been written before- you may want to read up on it. It is in the Arch extra repository, or you can get the source directly- http://projects.xennet.org/namcap. I don't know how big you are on python, but that is what namcap is written in. If there is any functionality in this script that isn't covered by namcap, that would be the place to put it. It needs an update anyway, it hasn't changed in a while.
Didn't know about that, I'll go and check it out. Andrew
On Thu, 29 Mar 2007 15:49:50 +0100
Andrew Fyfe
Wow, you went patch crazy! I have a lot of other things to do today so I probably won't be pushing some of this through quite yet, but hopefully it will get looked at soon. I'd also like to get Giovanni's gettext patch through first- we are going to have some conflicting merges with two big changes to makepkg, and I feel like it is easier to push his first. :D It's raining and I'm off college this week, not much to do lol.
When you get the gettext stuff in, I'll update the fakeroot patches. Until then I'll hold of on the rest of my patches, don't want to get labeled a patch whore :p
Patches are awesome - less a patch whore and more a patch master, extreme ruler of patches. :D -- Travis
participants (3)
-
Andrew Fyfe
-
Dan McGee
-
Travis Willard