[pacman-dev] Parsing config file question
Why does pacman do this... if(strcmp(key, "ShowSize") == 0 || strcmp(upperkey, "SHOWSIZE") == 0) Is there any reason why we can't do... if(strcmp(upperkey, "SHOWSIZE") == 0) Andrew PS Just found the ILoveCandy option :D
On Fri, Jul 27, 2007 at 03:13:35PM +0100, Andrew Fyfe wrote:
Why does pacman do this...
if(strcmp(key, "ShowSize") == 0 || strcmp(upperkey, "SHOWSIZE") == 0)
Is there any reason why we can't do...
if(strcmp(upperkey, "SHOWSIZE") == 0)
I know there has been some odd problems with turkish locale, but I don't know what the actual problem is. Aaron will know more. Look for example at this commit : http://www.archlinux.org/pipermail/pacman-dev/2007-April/007962.html
On 7/27/07, Andrew Fyfe <andrew@neptune-one.net> wrote:
Why does pacman do this...
if(strcmp(key, "ShowSize") == 0 || strcmp(upperkey, "SHOWSIZE") == 0)
Is there any reason why we can't do...
if(strcmp(upperkey, "SHOWSIZE") == 0)
http://bugs.archlinux.org/task/7235 That should explain most of it. What it came down to was options containing the 'i' character- in the Turkish locale, upper(LogFile) != LOGFILE. There are two 'i-like' characters, one with a dot and one without and it was causing issues. Thus the seemingly duplicate checks in our code. -Dan
On Fri, Jul 27, 2007 at 10:43:32AM -0400, Dan McGee wrote:
On 7/27/07, Andrew Fyfe <andrew@neptune-one.net> wrote:
Why does pacman do this...
if(strcmp(key, "ShowSize") == 0 || strcmp(upperkey, "SHOWSIZE") == 0)
Is there any reason why we can't do...
if(strcmp(upperkey, "SHOWSIZE") == 0)
http://bugs.archlinux.org/task/7235
That should explain most of it. What it came down to was options containing the 'i' character- in the Turkish locale, upper(LogFile) != LOGFILE. There are two 'i-like' characters, one with a dot and one without and it was causing issues. Thus the seemingly duplicate checks in our code.
Well, I couldn't find the explanation you just made in that bug report. Actually I couldn't find this information anywhere. Maybe the quick description you just made deserves to be in the code itself?
On 7/27/07, Xavier <shiningxc@gmail.com> wrote:
On Fri, Jul 27, 2007 at 10:43:32AM -0400, Dan McGee wrote:
On 7/27/07, Andrew Fyfe <andrew@neptune-one.net> wrote:
Why does pacman do this...
if(strcmp(key, "ShowSize") == 0 || strcmp(upperkey, "SHOWSIZE") == 0)
Is there any reason why we can't do...
if(strcmp(upperkey, "SHOWSIZE") == 0)
http://bugs.archlinux.org/task/7235
That should explain most of it. What it came down to was options containing the 'i' character- in the Turkish locale, upper(LogFile) != LOGFILE. There are two 'i-like' characters, one with a dot and one without and it was causing issues. Thus the seemingly duplicate checks in our code.
Well, I couldn't find the explanation you just made in that bug report. Actually I couldn't find this information anywhere. Maybe the quick description you just made deserves to be in the code itself?
Hmm, probably a good call. I'll put it on my TODO list. -Dan
participants (3)
-
Andrew Fyfe
-
Dan McGee
-
Xavier