[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.0.0-585-g2f55733
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 2f55733be35e7ec4188ddab17a92ed67faa7210d (commit) via c8243bb8ed2908e92d311a32d15e797dc83ba633 (commit) via f75ee7176235f2c1a531113985d715ddcafb6d05 (commit) via c244cfecf654d34032585530f00d68501ec63d77 (commit) via 8757398a7e3132166a2e20605c02dfdc2abc3d1d (commit) via ceb870655ec5c5efdd694328d0c4b8c98be99ebe (commit) via 7219326dd4d01d7e49b8a40746f5495c1c329c9c (commit) via f5fcaf0b3c8d05e94d08d6357324cfa69d8ceae7 (commit) via 1d57a3e801421f6ddd43522f1a0d1ebaacf7aa92 (commit) via 85b06f127600131e11afb3629e2609334dee00df (commit) from 46ec9e3548b5b567c7eb18c360f54a77b6313b12 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2f55733be35e7ec4188ddab17a92ed67faa7210d Author: Dan McGee <dan@archlinux.org> Date: Tue Nov 13 00:37:11 2007 -0600 Ensure -Si and -Qi output show correct dependencies Because alpm_pkg_get_depends() no longer returns strings as the data, we need to first convert the returned structures to printable strings before we can print the list. Signed-off-by: Dan McGee <dan@archlinux.org> commit c8243bb8ed2908e92d311a32d15e797dc83ba633 Author: Dan McGee <dan@archlinux.org> Date: Wed Nov 14 22:51:47 2007 -0600 libalpm: change graph malloc to MALLOC macro Signed-off-by: Dan McGee <dan@archlinux.org> commit f75ee7176235f2c1a531113985d715ddcafb6d05 Author: Dan McGee <dan@archlinux.org> Date: Wed Nov 14 22:51:16 2007 -0600 Fix alpm_list_copy_data So I spent a good 4 hours tracking a bug down tonight due to alpm_list_copy_data not actually doing what I expected to do. We can't find the size of an object we don't know the type of, so rewrite it so we pass in the size explicitly. This was making _alpm_pkg_dup fail and causing all sorts of other issues. Signed-off-by: Dan McGee <dan@archlinux.org> commit c244cfecf654d34032585530f00d68501ec63d77 Author: Dan McGee <dan@archlinux.org> Date: Mon Nov 12 23:01:14 2007 -0600 Move alpm_splitdep usage to db_read Holy inefficient batman! For a pacman -Qt operation (when we are using compute_requiredby and not database entries), splitdep was being called ~1.3 million times on my local database. By splitting when we read the DB, we drop this number to around 1700 and save a LOT of time in doing so (a 5x increase in pacman -Qt speed here). Note that the depends alpm_list_t in the package struct is no longer a string list, but a list of pmdepent_t objects. Signed-off-by: Dan McGee <dan@archlinux.org> commit 8757398a7e3132166a2e20605c02dfdc2abc3d1d Author: Dan McGee <dan@archlinux.org> Date: Mon Nov 12 21:28:13 2007 -0600 testdb: remove requiredby checking Signed-off-by: Dan McGee <dan@archlinux.org> commit ceb870655ec5c5efdd694328d0c4b8c98be99ebe Author: Dan McGee <dan@archlinux.org> Date: Mon Nov 12 19:45:03 2007 -0600 Remove REQUIREDBY checks from pactest Remove any checks dealing with requiredby from pactest (but not actually from the pactests themselves). Of course, we should probably find a new way to check requiredby values of packages since there is no guarantee our code is working perfectly. Signed-off-by: Dan McGee <dan@archlinux.org> commit 7219326dd4d01d7e49b8a40746f5495c1c329c9c Author: Dan McGee <dan@archlinux.org> Date: Mon Nov 12 19:40:08 2007 -0600 Remove REQUIREDBY usage from libalpm Instead of using the often-busted REQUIREDBY entries in the pacman database, compute them each time they are required. This should help many things: 1. Simplify the codebase 2. Prevent future database corruption 3. Ensure when we do use requiredby, it is always correct 4. Shrink the pmpkg_t memory overhead Signed-off-by: Dan McGee <dan@archlinux.org> commit f5fcaf0b3c8d05e94d08d6357324cfa69d8ceae7 Author: Nagy Gabor <ngaba@bibl.u-szeged.hu> Date: Wed Nov 14 20:02:47 2007 +0100 new trans001.py pactest The pactest demonstrates what happens if fileconflict was found after the removal part of a sync transaction. Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu> Signed-off-by: Dan McGee <dan@archlinux.org> commit 1d57a3e801421f6ddd43522f1a0d1ebaacf7aa92 Author: Nagy Gabor <ngaba@bibl.u-szeged.hu> Date: Wed Nov 14 19:56:41 2007 +0100 new add043.py pactest Currently alpm_depcmp uses pkg->version as a version number for provisions, which is odd. The failure of the pactest demonstrates this. Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu> Signed-off-by: Dan McGee <dan@archlinux.org> commit 85b06f127600131e11afb3629e2609334dee00df Author: Nagy Gabor <ngaba@bibl.u-szeged.hu> Date: Wed Nov 14 12:42:15 2007 +0100 alpm_list_add == alpm_list_add_last It's time to define that alpm_list_add(list, foo) adds 'foo' to the end of 'list' and returns with 'list', because: 1. list is a list, not a set. 2. sortbydeps _needs_ an alpm_list_add definition to work properly. As a first step, I used this definition in recursedeps. Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu> [Dan: punctuation cleanup in commit message and code comments, added comment to alpm_list_add] Signed-off-by: Dan McGee <dan@archlinux.org> ----------------------------------------------------------------------- Summary of changes: lib/libalpm/add.c | 7 --- lib/libalpm/alpm.h | 1 - lib/libalpm/alpm_list.c | 14 ++++--- lib/libalpm/alpm_list.h | 2 +- lib/libalpm/be_files.c | 19 +++------ lib/libalpm/db.c | 1 - lib/libalpm/deps.c | 96 +++++++++++++++++++------------------------- lib/libalpm/deps.h | 2 +- lib/libalpm/package.c | 45 ++++----------------- lib/libalpm/package.h | 2 - lib/libalpm/remove.c | 19 +++------ lib/libalpm/sync.c | 49 ----------------------- lib/libalpm/trans.c | 65 ------------------------------ lib/libalpm/trans.h | 1 - pactest/pmdb.py | 7 +--- pactest/pmpkg.py | 1 - pactest/pmrule.py | 3 - pactest/tests/add043.py | 15 +++++++ pactest/tests/trans001.py | 20 +++++++++ src/pacman/package.c | 28 ++++++++++++- src/pacman/query.c | 4 +- src/util/testdb.c | 44 -------------------- 22 files changed, 136 insertions(+), 309 deletions(-) create mode 100644 pactest/tests/add043.py create mode 100644 pactest/tests/trans001.py hooks/post-receive -- The official pacman repository
commit c244cfecf654d34032585530f00d68501ec63d77 Author: Dan McGee <dan@archlinux.org> Date: Mon Nov 12 23:01:14 2007 -0600
Move alpm_splitdep usage to db_read
Holy inefficient batman! For a pacman -Qt operation (when we are using compute_requiredby and not database entries), splitdep was being called ~1.3 million times on my local database. By splitting when we read the DB, we drop this number to around 1700 and save a LOT of time in doing so (a 5x increase in pacman -Qt speed here).
Note that the depends alpm_list_t in the package struct is no longer a string list, but a list of pmdepent_t objects.
Signed-off-by: Dan McGee <dan@archlinux.org> Small note: Storing pmdepend_t in pkgcache eats much more memory. Bye
---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/
On Nov 19, 2007 5:31 AM, Nagy Gabor <ngaba@bibl.u-szeged.hu> wrote:
commit c244cfecf654d34032585530f00d68501ec63d77 Author: Dan McGee <dan@archlinux.org> Date: Mon Nov 12 23:01:14 2007 -0600
Move alpm_splitdep usage to db_read
Holy inefficient batman! For a pacman -Qt operation (when we are using compute_requiredby and not database entries), splitdep was being called ~1.3 million times on my local database. By splitting when we read the DB, we drop this number to around 1700 and save a LOT of time in doing so (a 5x increase in pacman -Qt speed here).
Note that the depends alpm_list_t in the package struct is no longer a string list, but a list of pmdepent_t objects.
Signed-off-by: Dan McGee <dan@archlinux.org> Small note: Storing pmdepend_t in pkgcache eats much more memory.
Static length strings are what really kill us, so that is where the effort should be focused. I believe Aaron is going to address this. -Dan
participants (3)
-
Dan McGee
-
Dan McGee
-
Nagy Gabor