[pacman-dev] [PATCH] makepkg: install all dependencies simultanously, if possible when using rmdeps but not install, runtime dependencies do not need special handling for (non)removal, and can be installed in the same transaction. This allows pacman to intelligently resolve some things which would otherwise be conflicts.
From: Erich Eckner <git@eckner.net> Signed-off-by: Erich Eckner <git@eckner.net> --- scripts/makepkg.sh.in | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index e9080a70..625b89a2 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1607,18 +1607,18 @@ else fi deperr=0 - msg "$(gettext "Checking runtime dependencies...")" - resolve_deps ${depends[@]} || deperr=1 - if (( RMDEPS && INSTALL )); then + msg "$(gettext "Checking runtime dependencies...")" + resolve_deps ${depends[@]} || deperr=1 + original_pkglist=($(run_pacman -Qq)) # required by remove_dep fi msg "$(gettext "Checking buildtime dependencies...")" if (( CHECKFUNC )); then - resolve_deps "${makedepends[@]}" "${checkdepends[@]}" || deperr=1 + resolve_deps "${depends[@]}" "${makedepends[@]}" "${checkdepends[@]}" || deperr=1 else - resolve_deps "${makedepends[@]}" || deperr=1 + resolve_deps "${depends[@]}" "${makedepends[@]}" || deperr=1 fi if (( RMDEPS )); then -- 2.17.1
That subject is way too long. Please keep it around 50 chars if at all possible and put the more detailed explanation in the commit body. In this case it's probably best to simply end the subject at the first comma. Florian
On 06/08/2018 11:56 AM, Florian Pritz via pacman-dev wrote:
That subject is way too long. Please keep it around 50 chars if at all possible and put the more detailed explanation in the commit body. In this case it's probably best to simply end the subject at the first comma.
This was supposed to be: """ makepkg: install all dependencies simultanously, if possible when using rmdeps but not install, runtime dependencies do not need special handling for (non)removal, and can be installed in the same transaction. This allows pacman to intelligently resolve some things which would otherwise be conflicts. """ ... I was shown the patch on #archlinux32, and proposed a more detailed commit message body. Erich says it was supposed to have been multiple succeeding lines in the original commit message... I guess Allan can reflow it this once. ;) -- Eli Schwartz Bug Wrangler and Trusted User
Hi, sry, I'm new to git patches via email and commit messages suitably formatted for that - I didn't insert the newline between header and body. Should I resubmit the patch with a better formatted comit message? cheers, Erich On 08.06.2018 18:50, Eli Schwartz wrote:
On 06/08/2018 11:56 AM, Florian Pritz via pacman-dev wrote:
That subject is way too long. Please keep it around 50 chars if at all possible and put the more detailed explanation in the commit body. In this case it's probably best to simply end the subject at the first comma.
This was supposed to be:
""" makepkg: install all dependencies simultanously, if possible
when using rmdeps but not install, runtime dependencies do not need special handling for (non)removal, and can be installed in the same transaction. This allows pacman to intelligently resolve some things which would otherwise be conflicts. """
...
I was shown the patch on #archlinux32, and proposed a more detailed commit message body. Erich says it was supposed to have been multiple succeeding lines in the original commit message...
I guess Allan can reflow it this once. ;)
No. I'll handle it (post 5.1.1). Note there has been requests to install makedepends before depends. I guess installing both at the same time achieves the same outcome. Allan On 11/06/18 05:58, Erich Eckner wrote:
Hi,
sry, I'm new to git patches via email and commit messages suitably formatted for that - I didn't insert the newline between header and body. Should I resubmit the patch with a better formatted comit message?
cheers, Erich
On 08.06.2018 18:50, Eli Schwartz wrote:
On 06/08/2018 11:56 AM, Florian Pritz via pacman-dev wrote:
That subject is way too long. Please keep it around 50 chars if at all possible and put the more detailed explanation in the commit body. In this case it's probably best to simply end the subject at the first comma.
This was supposed to be:
""" makepkg: install all dependencies simultanously, if possible
when using rmdeps but not install, runtime dependencies do not need special handling for (non)removal, and can be installed in the same transaction. This allows pacman to intelligently resolve some things which would otherwise be conflicts. """
...
I was shown the patch on #archlinux32, and proposed a more detailed commit message body. Erich says it was supposed to have been multiple succeeding lines in the original commit message...
I guess Allan can reflow it this once. ;)
participants (5)
-
Allan McRae
-
arch＠eckner.net
-
Eli Schwartz
-
Erich Eckner
-
Florian Pritz