On Mon, Feb 20, 2006 at 10:47:46AM +0100, VMiklos wrote:

hi

http://frugalware.org/~vmiklos/patches/libpacman-proposed/alpm_db_cosmetics....

somehow these tabs are replaced with spaces

Applied. - J

On Mon, Feb 20, 2006 at 10:02:44PM +0100, Aurelien Foret <aurelien@archlinux.org> wrote:

Well, these spaces were added on purpose to ease readability.

There are lots of others instructions following this scheme in the whole code. If it does not fit your coding rules, please say it so.

if we use tabs, everyone is free to set tabspace to 2/8/etc in his favorite editor. if we use spaces, this freedom is lost the coding style in each project is different. for example in our projects we prefer tabs instead of spaces and curly brackets and the start of the line. as far as i see, the style at pacman is to have curly brackets at the end of the line and use tabs. that's why i sent the patch also in an other project where i was a contributor earlier (MPlayer) the rule was that everyone is allowed to use his favorite coding style, but no cosmetics is allowed if you think the current "homogeneous but cosmetics allowed" style at pacman is not proper, then let's discuss this udv / greetings, VMiklos -- Developer of Frugalware Linux, to make things frugal - http://frugalware.org

On Wed, Feb 22, 2006 at 10:29:49PM +0100, Aurelien Foret wrote:

The indentation I used is what GNU indent defines as "continue-at-parentheses" (tabs at the beginning of a line until reaching the code block, then shift it with some spaces to get the proper alignment).

This seems like a good method to me. That way the lower line will always line up X spaces to the right of the above line, regardless of tabstop width. High readability. - J