[pacman-dev] [PATCH] scripts: deduplicate localized copyright messages
Fixes FS#58452
Also consistently add a blank line after the copyright and before the
license terms.
Signed-off-by: Eli Schwartz
On 05/09/2018 12:12 AM, Eli Schwartz wrote:
Fixes FS#58452 Also consistently add a blank line after the copyright and before the license terms.
Signed-off-by: Eli Schwartz
Deferred until after 5.1 is released -- Eli Schwartz Bug Wrangler and Trusted User
On 9/5/18 2:12 pm, Eli Schwartz wrote:
Fixes FS#58452 Also consistently add a blank line after the copyright and before the license terms.
Signed-off-by: Eli Schwartz
--- Do the email address lines need to be translated? Anyway, currently updating the pacman copyright year dirties the translations. It could be interpolated but then the copyright year updating code needs to be as well.
Probably not... How about changing this:
printf -- "$(gettext "Copyright (c) 2006-2018 Pacman Development Team
On 9/18/18 7:51 AM, Allan McRae wrote:
On 9/5/18 2:12 pm, Eli Schwartz wrote:
Fixes FS#58452 Also consistently add a blank line after the copyright and before the license terms.
Signed-off-by: Eli Schwartz
--- Do the email address lines need to be translated? Anyway, currently updating the pacman copyright year dirties the translations. It could be interpolated but then the copyright year updating code needs to be as well.
Probably not... How about changing this:
printf -- "$(gettext "Copyright (c) 2006-2018 Pacman Development Team
.\n")" to:
printf -- "$(gettext "Copyright (c)") 2006-2018 Pacman Development Team
.\n" so just the "Copyright (c)" is translated?
From a quick grep, I'm seeing people translate the "Pacman Development Team" part and not the "Copyright". If we're going to translate just part of a copyright line, then (going by what our translators currently do) we should probably just explicitly translate "Pacman Development Team"... -- Eli Schwartz Bug Wrangler and Trusted User
On 18/9/18 11:10 pm, Eli Schwartz wrote:
On 9/18/18 7:51 AM, Allan McRae wrote:
On 9/5/18 2:12 pm, Eli Schwartz wrote:
Fixes FS#58452 Also consistently add a blank line after the copyright and before the license terms.
Signed-off-by: Eli Schwartz
--- Do the email address lines need to be translated? Anyway, currently updating the pacman copyright year dirties the translations. It could be interpolated but then the copyright year updating code needs to be as well.
Probably not... How about changing this:
printf -- "$(gettext "Copyright (c) 2006-2018 Pacman Development Team
.\n")" to:
printf -- "$(gettext "Copyright (c)") 2006-2018 Pacman Development Team
.\n" so just the "Copyright (c)" is translated?
From a quick grep, I'm seeing people translate the "Pacman Development Team" part and not the "Copyright".
If we're going to translate just part of a copyright line, then (going by what our translators currently do) we should probably just explicitly translate "Pacman Development Team"...
Hrm - I don't think that should be translated... Lets just not translate those lines. A
We don't need to translate the "Copyright YEAR AUTHOR" part, no part of
it should probably be translated and it definitely shouldn't turn every
single license terms notice into a separate translation just because the
author/year is different.
Fixes FS#58452
Also consistently add a blank line after the copyright and before the
license terms.
Signed-off-by: Eli Schwartz
participants (2)
-
Allan McRae
-
Eli Schwartz